add TODO

urlaubsverwaltung · May 21, 2023 · 87edffa · 87edffa
1 parent 13307a7
commit 87edffa
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/main/java/de/focusshift/zeiterfassung/overtime/OvertimeServiceImpl.java b/src/main/java/de/focusshift/zeiterfassung/overtime/OvertimeServiceImpl.java
@@ -34,7 +34,8 @@ public Map<UserLocalId, OvertimeDuration> accumulatedOvertimeToDate(LocalDate da
         final Map<String, UserLocalId> localIdById = userManagementService.findAllUsersByLocalIds(userLocalIds).stream()
             .collect(toMap(user -> user.id().value(), User::localId));
 
-        final Map<String, List<TimeEntryBreakEntityView>> byUserIdValue = overtimeRepository.getWorkDurationsToDate(false, localIdById.keySet(), dateExclusive)
+        // TODO create overtime snapshots (e.g. every month) so we don't have to read/calculate the whole past...
+        //      workDuration has to be considered with plannedWorkingHours to calculate the overtimeDuration. otherwise it's just... the actual worked hours...
         final Map<String, List<TimeEntryEntityDurationView>> byUserIdValue = overtimeRepository.getWorkDurationsToDate(false, localIdById.keySet(), dateExclusive)
             .stream()
             .collect(groupingBy(TimeEntryEntityDurationView::getUserId));