Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(graphCache) - warn when using an interface or union type in the resolvers #1304

Merged
merged 2 commits into from
Jan 13, 2021

Conversation

JoviDeCroock
Copy link
Collaborator

Resolves: #1293

Summary

Warn the user when using an abstract type in the resolvers config.

Set of changes

  • add dev-check to schema-predicates
  • add documentation for said error

@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2021

🦋 Changeset detected

Latest commit: 35d4e52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@urql/exchange-graphcache Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@andyrichardson andyrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dopeeee

@JoviDeCroock JoviDeCroock merged commit 42e8996 into main Jan 13, 2021
@JoviDeCroock JoviDeCroock deleted the warn-abstract-fields branch January 13, 2021 18:29
@github-actions github-actions bot mentioned this pull request Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Development mode validation of Graphcache resolver configuration against schema
3 participants