Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(next): Enable suspense in non-rsc example #3364

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

spiceee
Copy link
Contributor

@spiceee spiceee commented Aug 30, 2023

Summary

The non-rsc example is missing the suspense: true argument, so the query never runs on the server like the copy suggests.

Set of changes

Just enabling suspense in the docs, like it's done in the Next non-rsc example in https://github.com/urql-graphql/urql/blob/main/examples/with-next/app/non-rsc/layout.tsx

Copy link
Member

@kitten kitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@kitten kitten merged commit 7ee3678 into urql-graphql:main Aug 31, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants