Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphcache): Fix typo in owned data null resolution for resolvers #3371

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

kitten
Copy link
Member

@kitten kitten commented Sep 4, 2023

Resolves #3370

Summary

This fixes a typo in an inverted condition for an owned data check in resolveResolverResult. The equivalent check in resolveLink is isOwnedData && prevData === null, i.e. when a prior result was null it keeps the field set to null.

Instead, the resolver did the opposite and hence turned a first resolution of a prevData === null result into a nulled value, i.e. preventing subsequent results from succeeding.

Set of changes

  • Fix inverted resolveResolverResult condition for owned null values

@kitten kitten merged commit 022c7d2 into main Sep 4, 2023
6 checks passed
@kitten kitten deleted the fix/owned-data-resolvers branch September 4, 2023 16:16
@github-actions github-actions bot mentioned this pull request Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

null data has been returned after fetch done with valid data when using nested local resolver
1 participant