Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve nak pdu api #49

Merged
merged 6 commits into from
Oct 16, 2023
Merged

Improve nak pdu api #49

merged 6 commits into from
Oct 16, 2023

Conversation

robamu
Copy link
Contributor

@robamu robamu commented Oct 16, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (da17922) 96.29% compared to head (0032247) 96.32%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   96.29%   96.32%   +0.03%     
==========================================
  Files          84       84              
  Lines        6365     6451      +86     
==========================================
+ Hits         6129     6214      +85     
- Misses        236      237       +1     
Flag Coverage Δ
unittests 96.32% <98.43%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
spacepackets/cfdp/conf.py 100.00% <100.00%> (ø)
spacepackets/util.py 91.04% <100.00%> (+0.09%) ⬆️
tests/cfdp/pdus/test_nak_pdu.py 100.00% <100.00%> (ø)
tests/cfdp/test_header.py 100.00% <100.00%> (ø)
tests/test_util.py 97.61% <100.00%> (+0.08%) ⬆️
spacepackets/cfdp/pdu/nak.py 96.69% <89.47%> (-0.37%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robamu robamu merged commit 143e39c into main Oct 16, 2023
8 checks passed
@robamu robamu deleted the improve-nak-pdu-api branch October 16, 2023 14:46
@robamu robamu added this to the vNext milestone Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants