-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert observational data functions from httr
to httr2
#49
Open
Aariq
wants to merge
19
commits into
master
Choose a base branch
from
httr2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge commit 'f82ed20618f5c4e1879df7317b010eac8f4c2ac8' #Conflicts: # .Rbuildignore # DESCRIPTION # tests/fixtures/npn_species_search_1.yml # tests/fixtures/npn_species_search_2.yml # tests/fixtures/npn_species_state_1.yml # tests/fixtures/npn_species_state_2.yml # tests/fixtures/npn_stations_1.yml # tests/fixtures/npn_stations_2.yml # tests/fixtures/npn_stations_by_location_1.yml # tests/fixtures/npn_stations_with_spp_1.yml # tests/fixtures/npn_stations_with_spp_2.yml
Aariq
changed the title
Convert
Convert observational data functions from Nov 20, 2024
httr
to httr2
httr
to httr2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first piece of work transitioning from
httr
tohttr2
. This creates abase_req
inzzz.R
that is then used in all the modified functions to form the basic request. It includes only the API URL and a user agent for now, but could include rate limiting, retry, etc.Most functions are updated in the same way—instead of
npn_GET(<endpoint>, <query args>, ...)
they are now formed like:Possible breaking changes include:
data.frame
s. Tibbles are alsodata.frame
s, so this usually doesn't cause a problem. Where it might cause issues for users is when functions previously returnedNULL
(e.g. if there was an error) they now return a 0x0 tibble. I personally think this is an improvement, but we could keep the old behavior....
argument to functions no longer does anything (more in What to do about...
innpn_GET()
? #46)npn_get_phenophases_for_taxon()
now returns a tibble instead of a list (the documentation said it returned a data frame so I assumed this was a bug)npn_species_state()
now errors instead of returningNULL
when arguments are invalid. It sounded like this is the intended behavior from the documentation, but could mess up people's workflows