Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php 8.3 with Alpine 3.20 + GHA dependency upgrades #201

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

ricardofontanelli
Copy link
Contributor

@ricardofontanelli ricardofontanelli commented Nov 20, 2024

Usabilla PHP Docker Template

  • It add php 8.3 on alpine 3.20 as part of the build pipeline
  • upgrades actions/upload-artifact to v4
  • replaces the legacy docker compose syntax
  • adjusts one assertion related to php helper script tests

Reviewers: @usabilla/oss-docker

Type

Please specify the type of changes being proposed:

Q A
Documentation? no
Dockerfile change? no
Build feature? yes
Apply CVE Patch? no
Remove CVE Patch? no

Changelog

@rdohms
Copy link
Member

rdohms commented Nov 26, 2024

Looks like we need a rebase to get the new workflow update

@ricardofontanelli ricardofontanelli force-pushed the add-php83-with-alpine-320 branch 2 times, most recently from 32ac283 to e09eb55 Compare November 26, 2024 16:01
@ricardofontanelli ricardofontanelli force-pushed the add-php83-with-alpine-320 branch 3 times, most recently from 4c88699 to b1e4666 Compare November 26, 2024 18:11
In the latest builds after alpine 3.17, the proper file mode is 755.
@ricardofontanelli ricardofontanelli force-pushed the add-php83-with-alpine-320 branch from b1e4666 to 715716e Compare November 26, 2024 18:22
@ricardofontanelli
Copy link
Contributor Author

Looks like we need a rebase to get the new workflow update

Some other small changes were needed, since the GHA pipelines were fixed due to some dependency deprecations. Let me know if you prefer me to split this PR :)

@ricardofontanelli ricardofontanelli changed the title Add php 8.3 with Alpine 3.20 Add php 8.3 with Alpine 3.20 + GHA dependency upgrades Nov 26, 2024
@ricardofontanelli ricardofontanelli merged commit 1e379cf into master Nov 27, 2024
150 checks passed
@ricardofontanelli ricardofontanelli deleted the add-php83-with-alpine-320 branch November 27, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants