fix hint selector and tests

usablica · Jul 8, 2024 · 69e79ae · 69e79ae
1 parent 6de3db4
commit 69e79ae
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/src/packages/hint/remove.ts b/src/packages/hint/remove.ts
@@ -14,7 +14,7 @@ export function removeHints(hint: Hint) {
   for (const hintElement of Array.from(elements)) {
     const step = hintElement.getAttribute(dataStepAttribute);
 
-    if (!step) continue;
+    if (step === null) continue;
 
     removeHint(parseInt(step, 10));
   }

diff --git a/src/packages/hint/selector.ts b/src/packages/hint/selector.ts
@@ -12,6 +12,6 @@ export const hintElements = () =>
 
 export const hintElement = (stepId: number) =>
   queryElementsByClassName(
-    `.${hintClassName}[${dataStepAttribute}="${stepId}"]`,
+    `${hintClassName}[${dataStepAttribute}="${stepId}"]`,
     hintsContainer()
   )[0];
diff --git a/src/packages/hint/show.ts b/src/packages/hint/show.ts
@@ -2,7 +2,6 @@ import { Hint } from "./hint";
 import { hideHintClassName } from "./className";
 import { dataStepAttribute } from "./dataAttributes";
 import { removeClass } from "../../util/className";
-import { fetchHintItems } from "./hintItem";
 import { hintElement, hintElements } from "./selector";
 
 /**
@@ -22,7 +21,8 @@ export async function showHints(hint: Hint) {
       showHint(parseInt(step, 10));
     }
   } else {
-    await fetchHintItems(hint);
+    // or render hints if there are none
+    await hint.render();
   }
 }
 

diff --git a/src/packages/hint/showHints.cy.ts b/src/packages/hint/showHints.cy.ts
@@ -1,9 +1,9 @@
 context("ShowHints", () => {
   it("should render all hints using the data-hint attributes", () => {
-    cy.visit("./cypress/setup/index.html").then((window) => {
+    cy.visit("./cypress/setup/index.html").then(async (window) => {
       const instance = window.introJs.hint();
 
-      instance.showHints();
+      await instance.showHints();
 
       cy.get(".introjs-hint").should("have.length", 4);
     });