-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A11y improvements #1753
base: master
Are you sure you want to change the base?
A11y improvements #1753
Conversation
I should probably have opened this as Draft while I work on fixing the test. |
I have 9 out of 24 test failing even on master on my machine saying the snapshot are too different. |
I have only 6 test failing, all with less than 0.07 variance on Github Action. |
@afshinm Just let me know if you see anything visual regression I could fix, otherwise this PR is ready. |
Sounds good, thanks @mrleblanc101. Will have a look. |
@afshinm @mrleblanc101 Hey guys. I just wanted to point out, - this PR also fixes a related bug, wherein the anchor/button element had its https://github.com/usablica/intro.js/blob/v6.0.0/src/core/showElement.js#L79 The bug is a problem because it poses a critical Web Accessibility error. |
Fix #1752