-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(breaking): make FromIteratorFixed
more generic
#21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usbalbin
approved these changes
Jun 16, 2024
Thank you! :) 🎉 |
Merged
usbalbin
added a commit
that referenced
this pull request
Jun 16, 2024
## Breaking * #21 -feat(breaking): make FromIteratorFixed more generic Update `FromIteratorFixed` trait to avoid unnameable iterator type as type paramater in the trait ## Other changes * #22 - Some cleaning from additional clippy lints * #20 - fix: nightly flags and clippy warnings ## Thank you * @Daniel-Aaron-Bloom * @gwen-lg
usbalbin
added a commit
that referenced
this pull request
Jun 23, 2024
## Breaking * #21 -feat(breaking): make FromIteratorFixed more generic Update `FromIteratorFixed` trait to avoid unnameable iterator type as type paramater in the trait ## Other changes * #22 - Some cleaning from additional clippy lints * #20 - fix: nightly flags and clippy warnings * #24 - Migrate to use cargo readme * #25 - Use cargo readme in ci ## Thank you * @Daniel-Aaron-Bloom * @gwen-lg
usbalbin
added a commit
that referenced
this pull request
Jun 23, 2024
## Breaking * #21 -feat(breaking): make FromIteratorFixed more generic Update `FromIteratorFixed` trait to avoid unnameable iterator type as type paramater in the trait ## Other changes * #22 - Some cleaning from additional clippy lints * #20 - fix: nightly flags and clippy warnings * #24 - Migrate to use cargo readme * #25 - Use cargo readme in ci ## Thank you * @Daniel-Aaron-Bloom * @gwen-lg
usbalbin
added a commit
that referenced
this pull request
Jun 23, 2024
## Breaking * #21 -feat(breaking): make FromIteratorFixed more generic Update `FromIteratorFixed` trait to avoid unnameable iterator type as type paramater in the trait ## Other changes * #22 - Some cleaning from additional clippy lints * #20 - fix: nightly flags and clippy warnings * #24 - Migrate to use cargo readme * #25 - Use cargo readme in ci ## Thank you * @Daniel-Aaron-Bloom * @gwen-lg
usbalbin
added a commit
that referenced
this pull request
Jun 23, 2024
## Breaking * #21 -feat(breaking): make FromIteratorFixed more generic Update `FromIteratorFixed` trait to avoid unnameable iterator type as type paramater in the trait ## Other changes * #22 - Some cleaning from additional clippy lints * #20 - fix: nightly flags and clippy warnings * #24 - Migrate to use cargo readme * #25 - Use cargo readme in ci ## Thank you * @Daniel-Aaron-Bloom * @gwen-lg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, it's not really possible to express
FromIteratorFixed
as a generic bound. For exampleThis is because the
FromIteratorFixed
currently locks in the iterator type at the trait level, while all theIteratorFixed
functions likemap
completely hide the type behindimpl Iterator
.The solution is to move the iterator type down to the
from_iter_fixed
method, only preserving theItem
type at the trait level. This is also logically correct as the specifics of the iterator type should not restrict implementations ofFromIteratorFixed
.This is technically a breaking change, but I don't think it's likely to impact any casual users of this crate, only downstream crates which do things like add implementations of
FromIteratorFixed
will have to perform minor updates to signatures.