-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all code/utils.py
to core/*
&& evaluate_h3cells
overhaul
#69
Conversation
I will let @anastassiavybornova review this one as it mostly touches her code. |
LOL Okay lazy bones. |
@martinfleis I think we'll actually want your eyes on a couple things for performance that @anastassiavybornova had mentioned when she made her original PR for this stuff. While I have reproduced her outputs (mostly) faithfully with some improved performance there is still the outstanding use of |
It looks okay to me. Is there some performance issue? Does it take hours or anything? |
OK, cool. For Auckland that notebook cell takes ≈2 seconds to run. I wasn't sure if there was some easy adjustment or clever spatial join that could be done to cut that time. At any rate, I think good enough for now and we can revisit if it becomes a problem with larger AOIs. |
If it took 20 minutes I would hesitate if it is worth any further attention. At 2s, you spend more reading this comment than what would you save in the end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks James for the housekeeping as always <3 and yes sure, agree for the performance, if there's no palpable issue let's just leave the .apply
(well, now it's .map
) inside the stats
functions
This is a hefty PR that:
code/utils.py
tocore/*
core.utils.py
core.stats.py
core.viz.h3_hex.py
evaluate_h3cells
functionality withincode/
hex_id
-- more robust than index locationcode/
as functionality is added tocore/
#63core.util.py
#62code
-->core
+ test #60