Removing the "Upcoming Closing Dates" Section in Dashboard

[mayabose]

Ticket #3155

Description

This ticket removes any code related to the upcoming dates section in the Dashboard, allowing the Recent Activity table to become larger.

• The b-col container for the Upcoming Closing Dates is removed
• The first b-col cols="1" container is removed to allow the Recent Activity container to shift left
• Unused styling and script code/imports relating to the Upcoming Closing Dates are removed

Screenshots / Testing

Previous Dashboard:

New Dashboard:

Checklist

• Provided ticket and description
• Provided screenshots/demo
• Provided testing information
• Provided adequate test coverage for all new code
• Added PR reviewers

[mayabose]

Not sure if I caught all the now-unused code in styling and script, I might have missed something?

[github-actions]

QA Summary

QA Check	Result
🌐 Client Tests	✅
🔗 Server Tests	✅
🤝 E2E Tests	✅
📏 ESLint	✅
🧹 TFLint	✅

Test Coverage

Coverage report for `packages/client`

St	File	% Stmts	% Branch	% Funcs	% Lines	Uncovered Line #s
🔴	All files	27.9	21.14	33.41	28.2
🔴	src	0	100	100	0
🔴	App.vue	0	100	100	0	9
🔴	src/arpa_reporter	0	100	100	0
🔴	App.vue	0	100	100	0	13
🟡	...ter/components	60.31	40.9	66.66	60.31
🟢	AlertBox.vue	100	50	100	100	35
🟡	...oadButton.vue	57.14	100	57.14	57.14	60-67
🟢	...ileButton.vue	100	100	100	100
🟢	...ttonSmall.vue	100	100	100	100
🟢	...mplateBtn.vue	100	100	100	100
🟡	...avigation.vue	65	100	62.5	65	213-219,228-235
🔴	StandardForm.vue	37.5	25	55.55	37.5	124-128,135-157
🟢	...porter/helpers	84.61	79.48	87.5	84.61
🟢	form-helpers.js	84.21	79.48	85.71	84.21	7,16,25,81-83
🟢	short-uuid.js	100	100	100	100
🔴	...eporter/router	0	0	0	0
🔴	index.js	0	0	0	0	21-135
🔴	...reporter/store	4.85	0	2.17	5.1
🔴	index.js	4.85	0	2.17	5.1	13-16,34-263
🔴	...reporter/views	35.76	19.37	54.23	35.76
🟢	AgenciesView.vue	100	100	100	100
🔴	AgencyView.vue	38.09	30	50	38.09	53-62,70-96
🔴	HomeView.vue	16.66	5	50	16.66	113,137-207
🔴	LoginView.vue	22.22	10	28.57	22.22	72-100
🔴	...plateView.vue	17.85	16.66	62.5	17.85	69-113
🔴	...ploadView.vue	22.22	6.25	36.36	22.22	30-31,116-144
🔴	...eriodView.vue	45	20	75	45	64-90
🔴	...riodsView.vue	40	33.33	66.66	40	132,149-171
🔴	...pientView.vue	25.8	6.25	30.76	25.8	73-93,110-152
🟡	...ientsView.vue	50	12.5	50	50	...46,165-190,203
🔴	UploadView.vue	49.12	47.61	78.94	49.12	...41-442,448-449
🔴	UploadsView.vue	44.44	40.9	66.66	44.44	...61-264,272-287
🔴	UserView.vue	40.62	20	68.75	40.62	84,97-137
🟡	UsersView.vue	60	16.66	62.5	60	91-92,105-107,123
🔴	...ationView.vue	25	4.16	29.62	25	...19,238,246-270
🔴	src/components	41.15	36.15	50.74	41.15
🟡	...vityTable.vue	69.23	45	100	69.23	164-170,185
🔴	BaseLayout.vue	45.45	100	44.44	45.45	220-232
🔴	CopyButton.vue	33.33	100	33.33	33.33	43-49
🔴	GrantsTable.vue	43.07	35.8	47.22	43.07	...51-455,463-543
🔴	...dUploader.vue	14.81	18.18	50	14.81	74-111
🔴	SearchFilter.vue	27.77	33.33	33.33	27.77	48-52,64,67,72-82
🔴	UserAvatar.vue	37.5	25	100	37.5	31-37
🔴	...ponents/Modals	21.45	7.2	32.81	21.53
🔴	...anization.vue	18.75	0	22.22	18.75	143-178
🔴	AddTeam.vue	45	25	58.33	45	204,210,216-245
🔴	AddUser.vue	40.9	33.33	64.28	40.9	...40,145,148-176
🔴	...anization.vue	20	0	16.66	20	58-78
🔴	EditTeam.vue	12.19	0	30.76	12.19	208-301
🔴	EditUser.vue	18.75	0	28.57	18.75	101-128
🔴	...ilsLegacy.vue	2.5	0	0	2.5	205-369
🔴	ImportTeams.vue	40	0	60	40	64-69,81-82
🔴	ImportUsers.vue	33.33	0	50	33.33	65-80
🔴	...archPanel.vue	21.21	14.28	25	21.21	...68-178,211-255
🔴	SearchPanel.vue	22.41	12	32	22.8	...83-386,392-470
🔴	src/helpers	16.96	20	17.14	17.43
🟢	constants.js	100	100	100	100
🟢	currency.js	100	100	100	100
🟢	dates.js	100	100	100	100
🔴	fetchApi.js	5.71	16.66	5.88	5.71	9-97
🔴	filters.js	4	0	0	4.54	19-51
🔴	form-helpers.js	0	0	0	0	5-82
🟡	gtag.js	77.77	90	75	77.77	12,51
🟢	...s/featureFlags	90.9	100	80	90.9
🟡	index.js	66.66	100	66.66	66.66	8
🟢	utils.js	100	100	100	100
🔴	src/mixin	20	0	28.57	20
🔴	...zableTable.js	20	0	28.57	20	16-31,36-37,42
🔴	src/router	21.05	16.66	15.78	21.05
🔴	index.js	21.05	16.66	15.78	21.05	...94-195,199-218
🟢	src/store	100	100	100	100
🟢	index.js	100	100	100	100
🔴	src/store/modules	3.58	0	4.72	3.77
🔴	agencies.js	5.26	100	8.33	5.55	13-70
🔴	alerts.js	20	100	20	20	10-24
🔴	grants.js	1.41	0	1.05	1.49	58-352
🔴	organization.js	33.33	100	33.33	33.33	21-25
🔴	roles.js	20	100	20	25	13-22
🔴	tenants.js	11.11	100	14.28	12.5	13-32
🔴	users.js	2.43	0	4.76	2.5	17-100
🔴	src/views	29.22	13.51	33.33	28.89
🔴	...orterView.vue	7.4	0	7.69	7.4	109-151
🔴	...boardView.vue	27.77	0	36.36	27.77	81,89-98,114-125
🔴	...tailsView.vue	14.45	0	17.94	14.45	...60-521,527-554
🟢	GrantsView.vue	100	100	100	100
🔴	LoginView.vue	23.52	10	28.57	23.52	107-134
🟢	MyGrantsView.vue	85.71	100	80	85.71	69
🟡	...ofileView.vue	77.77	66.66	75	77.77	130-134
🟢	NotFoundView.vue	100	100	100	100
🔴	...tionsView.vue	45.45	100	40	45.45	87,97-100,114-118
🔴	...ivityView.vue	33.33	18.75	42.85	33.33	...01,114,120-134
🟡	TeamsView.vue	54.54	100	50	54.54	142,156-163
🔴	UsersView.vue	44.44	50	44.44	44.44	116-121,133-139

Coverage report for `packages/server`

St	File	% Stmts	% Branch	% Funcs	% Lines	Uncovered Line #s
🟡	All files	58.31	50.73	53.94	58.41
🟢	src	81.63	33.33	60	81.63
🟢	configure.js	81.63	33.33	60	81.63	42,61-68,97-99
🟢	src/arpa_reporter	98.75	66.66	100	98.75
🟢	configure.js	97.36	40	100	97.36	36
🟢	environment.js	100	100	100	100
🟢	use-request.js	100	100	100	100
🔴	src/arpa_reporter/db	38.58	32.92	44.44	40.16
🔴	arpa-subrecipients.js	13.15	4.34	15.38	14.28	23-92
🔴	reporting-periods.js	37.2	46.87	40	38.09	46,77-156
🟢	settings.js	100	83.33	100	100	13
🟡	uploads.js	50	28.57	52.38	51.42	18-29,84,99-124,141-150
🔴	src/arpa_reporter/lib	29.57	33.08	34.56	28.46
🟢	arpa-ec-codes.js	100	100	100	100
🔴	audit-report.js	21.44	19.35	24.19	21.32	...28-529,554-684,732-758
🟡	ensure-async-context.js	75	100	50	100
🟢	format.js	90.62	90	90	91.3	41-42
🟡	log.js	75	50	50	75	13,25
🟡	preconditions.js	66.66	33.33	100	66.66	3
🔴	spreadsheet.js	9.09	0	0	9.09	15-32
🟢	validation-error.js	85.71	100	50	85.71	16
🔴	src/arpa_reporter/routes	40	14.92	14.28	40.6
🔴	agencies.js	22.58	0	0	23.33	13-21,26-53
🟡	application_settings.js	75	100	0	75	10-11
🟡	audit-report.js	68.91	58.33	100	68.91	57-58,64-78,100-116
🟢	exports.js	81.42	83.33	100	81.42	61-75,98-99
🔴	reporting-periods.js	20	0	0	20.43	...25-137,143-149,154-180
🔴	subrecipients.js	23.8	0	0	23.8	12-13,17-27,31-48,52-63
🔴	uploads.js	28.28	7.89	9.09	29.16	...33-154,164-166,173-180
🔴	users.js	19.6	0	0	20	15-35,39-44,48-81
🔴	src/arpa_reporter/services	42.83	30.41	45.71	43.22
🔴	generate-arpa-report.js	36.86	2.79	50	37.24	...-974,983-996,1070-1137
🔴	get-template.js	21.62	0	0	21.62	18-79
🟡	persist-upload.js	68.6	90	69.56	68.67	...58-200,221-235,273-295
🔴	records.js	20.75	0	11.11	21.15	38-204,221-276
🔴	revalidate-uploads.js	37.5	100	0	37.5	5-14
🔴	validate-upload.js	38.86	50.6	33.33	39.81	...20,339,361,379-656,671
🟢	validation-rules.js	98.18	90	90.9	100	157,173
🟡	src/db	74.3	71.42	68.42	74.33
🟢	connection.js	100	50	100	100	6
🟢	constants.js	100	100	100	100
🟡	helpers.js	75	83.33	50	75	5,21-22
🟢	index.js	82.44	78.54	82.08	82.38	...50-1416,1598-1599,1606
🟢	saved_search_migration.js	92	88.23	71.42	93.61	5,69,134
🔴	tenant_creation.js	10.58	2.7	0	11.11	15-40,48-210,220
🔴	src/db/arpa_reporter_db_shims	23.68	0	0	23.68
🔴	agencies.js	22.22	100	0	22.22	11-51
🔴	users.js	25	0	0	25	12-62
🟢	src/lib	86	79.51	91.42	85.94
🟢	access-helpers.js	93.54	89.18	100	93.54	96-97,102-103
🟢	agencyImporter.js	90.38	88.46	100	90.19	26,29,35,93-94
🟢	email.js	93.78	82.25	100	93.67	...38,160-164,211,424-427
🔴	gost-aws.js	47.82	37.5	42.85	47.72	13-58,94,104,114-134
🟢	grants-ingest.js	83.33	97.5	90	83.33	...28-131,138-140,155-159
🟡	logging.js	77.77	85.71	100	77.77	11,13
🟢	redirect_validation.js	100	100	100	100
🟢	userImporter.js	82.27	58.33	88.88	81.57	32,47,53,62,73-81,143-152
🔴	src/lib/annualReports	27.38	0	0	27.38
🔴	doc-builder.js	7.69	0	0	7.69	19-352
🟡	index.js	80	100	0	80	6
🟢	placeholderTextStrings.js	100	100	100	100
🔴	reportBuilder.js	17.24	0	0	17.24	21-33,50-62,86-103
🟢	src/lib/arpa_reporter_shims	100	100	100	100
🟢	email.js	100	100	100	100
🟢	src/lib/email	93.1	87.5	100	92.59
🟢	[constants.js](https://github.com/usdigitalresponse/usdr-gost/bl...*[Comment body truncated]*

[github-actions]

Terraform Summary

Step	Result
🖌 Terraform Format & Style	✅
⚙️ Terraform Initialization	✅
🤖 Terraform Validation	✅
📖 Terraform Plan	✅

Hint: If "Terraform Format & Style" failed, run terraform fmt -recursive from the terraform/ directory and commit the results.

Output

Validation Output

stdout:
Success! The configuration is valid.


-------------------------------------
stderr:

Plan Summary

CHANGE	RESOURCE
add	module.website.aws_s3_object.origin_dist_artifact["assets/ActivityTable-Cn6c22pI.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/ActivityTable-Cn6c22pI.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/DashboardView-Ca4-FCSN.css"]
	module.website.aws_s3_object.origin_dist_artifact["assets/DashboardView-D95X5Qfk.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/DashboardView-D95X5Qfk.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/GrantDetailsLegacy-DS2KnWwh.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/GrantDetailsLegacy-DS2KnWwh.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/GrantDetailsView-Cq4niDtM.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/GrantDetailsView-Cq4niDtM.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/GrantsTable-C3JTiVdn.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/GrantsTable-C3JTiVdn.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/GrantsView-CmTAuHxf.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/GrantsView-CmTAuHxf.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/MyGrantsView-CksTGHGh.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/MyGrantsView-CksTGHGh.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/MyProfileView-0UwrweWS.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/MyProfileView-0UwrweWS.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/OrganizationsView-3MKl0hCo.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/OrganizationsView-3MKl0hCo.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/RecentActivityView-CKCXOoEE.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/RecentActivityView-CKCXOoEE.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/TeamsView-vH9COzLB.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/TeamsView-vH9COzLB.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/UsersView-D3lRK_wx.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/UsersView-D3lRK_wx.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/currency-KwzSkwrz.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/currency-KwzSkwrz.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/main-BMxf5HSa.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/main-BMxf5HSa.js.map"]
update	module.api.aws_ecs_service.default[0]
	module.api.module.grant_digest_scheduled_task.aws_iam_role_policy.default[0]
	module.api.module.grant_digest_scheduled_task.aws_scheduler_schedule.default[0]
	module.arpa_audit_report.aws_ecs_service.default
	module.arpa_treasury_report.aws_ecs_service.default
	module.consume_grants.aws_ecs_service.default
	module.website.aws_s3_object.deploy-config[0]
	module.website.aws_s3_object.origin_dist_artifact["index.html"]
recreate	module.api.aws_ecs_task_definition.default[0]
	module.arpa_audit_report.aws_ecs_task_definition.consumer
	module.arpa_treasury_report.aws_ecs_task_definition.consumer
	module.consume_grants.aws_ecs_task_definition.consume_grants
delete	module.website.aws_s3_object.origin_dist_artifact["assets/ActivityTable-DtUQwh-6.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/ActivityTable-DtUQwh-6.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/ClosingDatesTable-B-Zo2w8C.css"]
	module.website.aws_s3_object.origin_dist_artifact["assets/ClosingDatesTable-BjBZjrPX.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/ClosingDatesTable-BjBZjrPX.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/DashboardView-BufnXip6.css"]
	module.website.aws_s3_object.origin_dist_artifact["assets/DashboardView-Db3H37ei.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/DashboardView-Db3H37ei.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/GrantDetailsLegacy-DVPCVgVk.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/GrantDetailsLegacy-DVPCVgVk.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/GrantDetailsView-Ddhnd5OW.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/GrantDetailsView-Ddhnd5OW.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/GrantsTable-BFfSB2Vp.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/GrantsTable-BFfSB2Vp.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/GrantsView-DKCJ_jbq.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/GrantsView-DKCJ_jbq.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/MyGrantsView-DJxJe_T-.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/MyGrantsView-DJxJe_T-.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/MyProfileView-C3X2Zkfr.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/MyProfileView-C3X2Zkfr.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/OrganizationsView-Vk8FcsCo.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/OrganizationsView-Vk8FcsCo.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/RecentActivityView-Bd4dNqok.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/RecentActivityView-Bd4dNqok.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/TeamsView-GcdqmjDY.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/TeamsView-GcdqmjDY.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/UpcomingClosingDatesView-Ad74N4oR.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/UpcomingClosingDatesView-Ad74N4oR.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/UpcomingClosingDatesView-DLEK_6k4.css"]
	module.website.aws_s3_object.origin_dist_artifact["assets/UsersView-B24_smj8.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/UsersView-B24_smj8.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/currency-DP10dQq3.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/currency-DP10dQq3.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/dates-BfVqbioQ.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/dates-BfVqbioQ.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/datetime-lqzArHOP.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/datetime-lqzArHOP.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/main-DU1xiJl2.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/main-DU1xiJl2.js.map"]
	module.website.aws_s3_object.origin_dist_artifact["assets/resizableTable-DO8hShBJ.js"]
	module.website.aws_s3_object.origin_dist_artifact["assets/resizableTable-DO8hShBJ.js.map"]

Pusher: @mayabose, Action: pull_request_target, Workflow: Continuous Integration

[TylerHendrickson]

@mayabose This is a good start – visually, things are looking as I'd expect them to.

re your comment

Not sure if I caught all the now-unused code in styling and script, I might have missed something?

There are a few client-side items mentioned in #3155 that haven't been addressed yet:

• Delete the packages/client/src/components/ClosingDatesTable.vue component file and refactor the packages/client code to remove any/all remaining usages.
• Delete the packages/client/src/views/UpcomingClosingDatesView.vue view file and refactor the packages/client code to remove any/all remaining usages, including its Vue route and any API calls.

These files need to be actually deleted (once a file is deleted locally, you can use git add to stage the "change" as you would do with a modified file). Deleting the files locally and then running the client-side unit tests (yarn test:client) should help uncover any other changes that might need to be made to the packages/server/ code.

Additionally, there are some API-side changes (also listed in #3155) that are still required before this PR can be approved:

API-side changes

• In packages/server/src/routes/grants.js, remove the /closestGrants/:perPage/:currentPage API route handler.
• In packages/server/src/db/index.js, remove the getClosestGrants() function, which should no remaining callers following removal of the /closestGrants/:perPage/:currentPage route.
• Check for and prune any/all other "dead code" that results from removing the /closestGrants/:perPage/:currentPage route (including unit tests, which may now be failing).

Let me know if anything in those remaining changes is unclear and we can chat further 🙂

[mayabose]

Totally missed the second half of the original ticket - so sorry about that! However, I think I may still be missing some instances related to /closestGrants/:perPage/:currentPage? I didn't end up removing much code related to that; I wasn't totally sure on where to look.

[TylerHendrickson]

Looks great – approved!