chore(grants): upgrade vitest so we can take advantage of more accessible queries #3635

lsr-explore · 2024-10-14T03:13:53Z

Ticket #

Description

Upgrade vitest so we can take advantage of more accessible queries
Locators available in vitest 2.1.2

Thanks to @phm200 for proposing this!

Screenshots / Demo Video

Testing

Automated and Unit Tests

Added Unit tests

Manual tests for Reviewer

Added steps to test feature/functionality manually

Checklist

Provided ticket and description
Provided screenshots/demo
Provided testing information
Provided adequate test coverage for all new code
Added PR reviewers

github-actions · 2024-10-14T03:18:15Z

QA Summary

QA Check	Result
🌐 Client Tests	❌
🔗 Server Tests	✅
🤝 E2E Tests	✅
📏 ESLint	✅
🧹 TFLint	✅

Test Coverage

Coverage report for `packages/client`

Coverage report for `packages/server`

St	File	% Stmts	% Branch	% Funcs	% Lines	Uncovered Line #s
🟡	All files	59.96	53.22	55.69	60.07
🟢	src	81.81	0	50	81.81
🟢	configure.js	81.81	0	50	81.81	47-54,83-85
🟢	src/arpa_reporter	100	71.42	100	100
🟢	configure.js	100	33.33	100	100	34-41
🟢	environment.js	100	100	100	100
🟢	use-request.js	100	100	100	100
🟡	src/arpa_reporter/db	50.73	45.88	50	51.9
🟡	arpa-subrecipients.js	53.19	50	38.46	54.54	23-60,101,113-122
🔴	reporting-periods.js	37.2	46.87	40	38.09	46,77-156
🟢	settings.js	100	83.33	100	100	13
🟡	uploads.js	50	28.57	52.38	51.42	18-29,84,99-124,141-150
🔴	src/arpa_reporter/lib	29.57	33.08	34.56	28.46
🟢	arpa-ec-codes.js	100	100	100	100
🔴	audit-report.js	21.44	19.35	24.19	21.32	...28-529,554-684,732-758
🟡	ensure-async-context.js	75	100	50	100
🟢	format.js	90.62	90	90	91.3	41-42
🟡	log.js	75	50	50	75	13,25
🟡	preconditions.js	66.66	33.33	100	66.66	3
🔴	spreadsheet.js	9.09	0	0	9.09	15-32
🟢	validation-error.js	85.71	100	50	85.71	16
🔴	src/arpa_reporter/routes	40	14.92	14.28	40.6
🔴	agencies.js	22.58	0	0	23.33	13-21,26-53
🟡	application_settings.js	75	100	0	75	10-11
🟡	audit-report.js	68.91	58.33	100	68.91	57-58,64-78,100-116
🟢	exports.js	81.42	83.33	100	81.42	61-75,98-99
🔴	reporting-periods.js	20	0	0	20.43	...25-137,143-149,154-180
🔴	subrecipients.js	23.8	0	0	23.8	12-13,17-27,31-48,52-63
🔴	uploads.js	28.28	7.89	9.09	29.16	...33-154,164-166,173-180
🔴	users.js	19.6	0	0	20	15-35,39-44,48-81
🔴	src/arpa_reporter/services	44.55	34.79	47.55	44.83
🔴	generate-arpa-report.js	36.86	2.77	50	37.24	...-975,984-997,1071-1138
🔴	get-template.js	21.62	0	0	21.62	18-79
🟡	persist-upload.js	69.66	90	73.07	69.76	...64-206,227-241,279-301
🔴	records.js	20.75	0	11.11	21.15	38-204,221-276
🔴	revalidate-uploads.js	37.5	100	0	37.5	5-14
🔴	validate-upload.js	43.56	58.51	37.03	44.2	...52,371,393,411-688,703
🟢	validation-rules.js	98.18	90	90.9	100	157,173
🟡	src/db	73.78	70.28	68	73.89
🟢	connection.js	100	50	100	100	6
🟢	constants.js	100	100	100	100
🟡	helpers.js	75	83.33	50	75	5,21-22
🟢	index.js	81.51	76.8	81.15	81.56	...97-1463,1645-1646,1653
🟢	saved_search_migration.js	92	88.23	71.42	93.61	5,69,134
🔴	tenant_creation.js	10.58	2.7	0	11.11	15-40,48-210,220
🔴	src/db/arpa_reporter_db_shims	23.68	0	0	23.68
🔴	agencies.js	22.22	100	0	22.22	11-51
🔴	users.js	25	0	0	25	12-62
🟢	src/lib	86.25	79.48	90.9	86.2
🟢	access-helpers.js	93.75	89.18	100	93.75	104-105,110-111
🟢	agencyImporter.js	90.38	88.46	100	90.19	26,29,35,93-94
🟢	email.js	94.08	81.81	100	93.98	...53,175-179,226,439-442
🔴	gost-aws.js	47.82	37.5	42.85	47.72	13-58,94,104,114-134
🟢	grants-ingest.js	82.81	93.18	90	82.81	...37-140,147-149,164-168
🟢	logging.js	84	86.66	85.71	84	14,16,49,59
🟢	redirect_validation.js	100	100	100	100
🟢	userImporter.js	82.27	58.33	88.88	81.57	32,47,53,62,73-81,143-152
🔴	src/lib/annualReports	27.38	0	0	27.38
🔴	doc-builder.js	7.69	0	0	7.69	19-352
🟡	index.js	80	100	0	80	6
🟢	placeholderTextStrings.js	100	100	100	100
🔴	reportBuilder.js	17.24	0	0	17.24	21-33,50-62,86-103
🟢	src/lib/arpa_reporter_shims	100	100	100	100
🟢	email.js	100	100	100	100
🟢	src/lib/email	93.1	87.5	100	92.59
🟢	constants.js	100	100	100	100
🟢	email-nodemailer.js	88.23	83.33	100	86.66	33,64
🟢	service-email.js	100	100	100	100
🟢	src/lib/fieldConfigs	100	100	100	100
🟢	fundingActivityCategories.js	100	100	100	100
🟢	src/lib/grantsCollaboration	98.11	82.92	100	98.11
🟢	followers.js	95	83.33	100	95	7
🟢	index.js	100	100	100	100
🟢	notes.js	100	82.75	100	100	40-80
🟡	src/routes	71.79	62.34	64.28	71.64
🔴	agencies.js	42.39	30	33.33	42.39	...13-121,125-146,154-160
🔴	annualReports.js	47.05	100	0	47.05	15-27
🟢	eligibilityCodes.js	100	100	100	100
🟢	grants.js	81.17	68.96	77.5	81.04	...01-524,547-551,570-571
🟡	grantsSavedSearch.js	80	83.33	100	80	38-39,56-57,70-72,78
🟢	health.js	100	100	100	100
🟡	interestedCodes.js	71.42	100	0	71.42	7-8
🟢	keywords.js	86.95	50	100	86.95	26-27,34
🟡	roles.js	75	100	0	75	8-9
🟡	searchConfig.js	58.33	100	0	58.33	9-14
🟡	sessions.js	63.93	39.39	50	63.93	...-73,79-80,84-85,98-104
🔴	tenants.js	39.13	0	0	39.13	11-12,16-27,32-35
🟢	users.js	80.41	74.19	85.71	80.41	...17,134-136,160,169-177
🟢	src/scripts	84.61	83.33	66.66	91.66
🟢	sendGrantDigestEmail.js	84.61	83.33	66.66	91.66	28

Pusher: @lsr-explore, Action: pull_request_target, Workflow: Continuous Integration

github-actions · 2024-10-14T03:19:58Z

Terraform Summary

Step	Result
🖌 Terraform Format & Style	✅
⚙️ Terraform Initialization	✅
🤖 Terraform Validation	✅
📖 Terraform Plan	✅

Hint: If "Terraform Format & Style" failed, run terraform fmt -recursive from the terraform/ directory and commit the results.

Output

Validation Output

stdout:
Success! The configuration is valid.


-------------------------------------
stderr:

Plan Summary

CHANGE	RESOURCE
add	`module.website.aws_s3_object.origin_dist_artifact["assets/ActivityTable-ogAGtWam.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/ActivityTable-ogAGtWam.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/ArpaAnnualPerformanceReporterView-ZgZ9bPNi.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/ArpaAnnualPerformanceReporterView-ZgZ9bPNi.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/DashboardView-CsyBUcKS.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/DashboardView-CsyBUcKS.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/GrantDetailsLegacy-CVzLycdU.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/GrantDetailsLegacy-CVzLycdU.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/GrantDetailsView-CyH0vOFb.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/GrantDetailsView-CyH0vOFb.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/GrantsTable-BRnyWZPP.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/GrantsTable-BRnyWZPP.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/GrantsView-BfScnu4t.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/GrantsView-BfScnu4t.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/MyGrantsView-BvA8snWF.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/MyGrantsView-BvA8snWF.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/MyProfileView-DEqvqGp1.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/MyProfileView-DEqvqGp1.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/NotFoundView-CUL58CEI.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/NotFoundView-CUL58CEI.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/OrganizationsView-CtlnXSRz.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/OrganizationsView-CtlnXSRz.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/RecentActivityView-Cu1cT-__.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/RecentActivityView-Cu1cT-__.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/RecordUploader-DrHOxz_S.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/RecordUploader-DrHOxz_S.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/TeamsView-9tdhQed6.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/TeamsView-9tdhQed6.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/UsersView-CmSCgtFz.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/UsersView-CmSCgtFz.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/arpa_reporter-BYIzXAo6.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/arpa_reporter-BYIzXAo6.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/form-helpers-DjfCffq7.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/form-helpers-DjfCffq7.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/main-D8MCf9Hp.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/main-D8MCf9Hp.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/style-BR5xq7AQ.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/style-BR5xq7AQ.js.map"]`
update	`module.api.aws_ecs_service.default[0]`
	`module.api.module.grant_digest_scheduled_task.aws_iam_role_policy.default[0]`
	`module.api.module.grant_digest_scheduled_task.aws_scheduler_schedule.default[0]`
	`module.arpa_audit_report.aws_ecs_service.default`
	`module.arpa_treasury_report.aws_ecs_service.default`
	`module.consume_grants.aws_ecs_service.default`
	`module.website.aws_s3_object.deploy-config[0]`
	`module.website.aws_s3_object.origin_dist_artifact["arpa_reporter/index.html"]`
	`module.website.aws_s3_object.origin_dist_artifact["index.html"]`
recreate	`module.api.aws_ecs_task_definition.default[0]`
	`module.arpa_audit_report.aws_ecs_task_definition.consumer`
	`module.arpa_treasury_report.aws_ecs_task_definition.consumer`
	`module.consume_grants.aws_ecs_task_definition.consume_grants`
delete	`module.website.aws_s3_object.origin_dist_artifact["assets/ActivityTable-C-fNyvid.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/ActivityTable-C-fNyvid.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/ArpaAnnualPerformanceReporterView-Dj53tT-d.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/ArpaAnnualPerformanceReporterView-Dj53tT-d.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/DashboardView-DmlKbw4l.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/DashboardView-DmlKbw4l.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/GrantDetailsLegacy-qfAfzqRW.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/GrantDetailsLegacy-qfAfzqRW.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/GrantDetailsView-CQom5-HV.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/GrantDetailsView-CQom5-HV.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/GrantsTable-DzJ43FsD.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/GrantsTable-DzJ43FsD.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/GrantsView-DlBPXiaD.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/GrantsView-DlBPXiaD.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/MyGrantsView-CiUuGyXF.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/MyGrantsView-CiUuGyXF.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/MyProfileView-BtD26M24.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/MyProfileView-BtD26M24.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/NotFoundView-BNjo2bz7.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/NotFoundView-BNjo2bz7.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/OrganizationsView-wKR95WV9.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/OrganizationsView-wKR95WV9.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/RecentActivityView-B2ZQgV4y.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/RecentActivityView-B2ZQgV4y.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/RecordUploader-DYH3QSlH.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/RecordUploader-DYH3QSlH.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/TeamsView-DwN2kQdA.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/TeamsView-DwN2kQdA.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/UsersView-BxE_93v7.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/UsersView-BxE_93v7.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/arpa_reporter-FFtEfd3s.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/arpa_reporter-FFtEfd3s.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/form-helpers-DlUFpH9K.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/form-helpers-DlUFpH9K.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/main-D8jDPxib.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/main-D8jDPxib.js.map"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/style-C_Ko3h6y.js"]`
	`module.website.aws_s3_object.origin_dist_artifact["assets/style-C_Ko3h6y.js.map"]`

Pusher: @lsr-explore, Action: pull_request_target, Workflow: Continuous Integration

phm200 · 2024-10-14T19:24:37Z

neat. I will keep an eye out for when this is ready for review

lsr-explore · 2024-12-12T17:27:05Z

Closing this as I don't recommend this approach.

github-actions bot added dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation javascript Pull requests that update Javascript code labels Oct 14, 2024

lsr-explore force-pushed the chore/upgrade-vite branch 2 times, most recently from c9f850e to 37a1206 Compare December 8, 2024 02:07

chore(gost): update version of vitest so we can use selectors

0cbbc68

lsr-explore force-pushed the chore/upgrade-vite branch from 37a1206 to 0cbbc68 Compare December 8, 2024 02:12

chore(gost): git ignore __screenshots__ folders

93fe009

github-actions bot added the github label Dec 8, 2024

lsr-explore mentioned this pull request Dec 9, 2024

chore(gost): update vitest version and add testing-library for accessible queries #3794

Merged

7 tasks

lsr-explore closed this Dec 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(grants): upgrade vitest so we can take advantage of more accessible queries #3635

chore(grants): upgrade vitest so we can take advantage of more accessible queries #3635

lsr-explore commented Oct 14, 2024

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

phm200 commented Oct 14, 2024

lsr-explore commented Dec 12, 2024

chore(grants): upgrade vitest so we can take advantage of more accessible queries #3635

chore(grants): upgrade vitest so we can take advantage of more accessible queries #3635

Conversation

lsr-explore commented Oct 14, 2024

Ticket #

Description

Screenshots / Demo Video

Testing

Automated and Unit Tests

Manual tests for Reviewer

Checklist

github-actions bot commented Oct 14, 2024 • edited Loading

QA Summary

Test Coverage

github-actions bot commented Oct 14, 2024 • edited Loading

Terraform Summary

Output

phm200 commented Oct 14, 2024

lsr-explore commented Dec 12, 2024

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading