Sync develop to master #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Thanks for the contribution, this is awesome. --> # PR Details ## Description This PR is to remove steps to build and run unit test for the carma-msgs repo. This already happens in carma-msgs repo CI and is not necessary for generating sonar scanner report. **Update**: Removed entire circle ci workflow since project does not require unit test code coverage it can use [automatic analysis](https://docs.sonarsource.com/sonarcloud/advanced-setup/automatic-analysis/?_gl=1*bpmykr*_gcl_aw*R0NMLjE3MDU0MjI3MDAuQ2p3S0NBaUE3NWl0QmhBNkVpd0FraG85ZTkyNGFDb2JVbjNKOHJJcWdzLUNZd2xsU1hVbGJaSnFlUFZybmYtZ0F0Z2hoRmNFcnVrQUZSb0NJOEVRQXZEX0J3RQ..*_gcl_au*MjAwNDcxNzU4Ny4xNzA5NzYyNjAz*_ga*MTc2NDc2NjYwNC4xNjc4MjAyNTQx*_ga_9JZ0GZ5TC6*MTcxMjkyODQ3Mi43MC4xLjE3MTI5Mjk1NDcuNjAuMC4w) from sonar scanner. This does not require a CI process and instead just runs static analysis on every PR and on every push to default branch <!--- Describe your changes in detail --> ## Related GitHub Issue <!--- This project only accepts pull requests related to open GitHub issues or Jira Keys --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please DO NOT name partially fixed issues, instead open an issue specific to this fix --> <!--- Please link to the issue here: --> ## Related Jira Key <!-- e.g. CAR-123 --> ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Defect fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that cause existing functionality to change) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I have added any new packages to the sonar-scanner.properties file - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have read the [**CONTRIBUTING**](https://github.com/usdot-fhwa-stol/carma-platform/blob/develop/Contributing.md) document. - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed.
<!-- Thanks for the contribution, this is awesome. --> # PR Details ## Description Waiting on PR #168 <!--- Describe your changes in detail --> ## Related GitHub Issue <!--- This project only accepts pull requests related to open GitHub issues or Jira Keys --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please DO NOT name partially fixed issues, instead open an issue specific to this fix --> <!--- Please link to the issue here: --> ## Related Jira Key <!-- e.g. CAR-123 --> ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Defect fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that cause existing functionality to change) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I have added any new packages to the sonar-scanner.properties file - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have read the [**CONTRIBUTING**](https://github.com/usdot-fhwa-stol/carma-platform/blob/develop/Contributing.md) document. - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed.
paulbourelly999
requested review from
kjrush,
MishkaMN,
JonSmet,
willjohnsonk,
dan-du-car and
SaikrishnaBairamoni
MishkaMN
requested changes
Apr 24, 2024
README.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| | Sonar Code Quality | DockerHub Release | DockerHub Release Candidate | DockerHub Develop | | |||
| |-----|-----|-----|-----| | |||
| [](https://sonarcloud.io/summary/new_code?id=usdot-fhwa-stol_carma-web-ui) | [](https://hub.docker.com/repository/docker/usdotfhwastol/carma-web-ui) | [](https://hub.docker.com/repository/docker/usdotfhwastolcandidate/carma-web-ui) | [](https://hub.docker.com/repository/docker/usdotfhwastoldev/carma-web-ui) | |||
| [](https://sonarcloud.io/summary/new_code?id=usdot-fhwa-stol_carma-web-ui) | [](https://github.com/usdot-fhwa-stol/carma-web-ui/actions/workflows/dockerhub.yml) | [](https://github.com/usdot-fhwa-stol/carma-web-ui/actions/workflows/dockerhub.yml) | [](https://github.com/usdot-fhwa-stol/carma-web-ui/actions/workflows/dockerhub.yml) | |||
There was a problem hiding this comment.
Looks like we decided on removing the candidate and release badges and keep develop at least. I will leave it up to you if you want to keep master as well. master is essentially "carma-system" tagges ones anyways, so we can also omit in my opinion
|
MishkaMN
approved these changes
Apr 24, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
This is an intermediate branch cut from master which includes fixes to the branch coupling of build and checkout scripts. This coupling can not yet be removed from CI processes because this repository still uses CircleCI. The functionality to decouple CI from branches is currently only available through our GitHub actions
Related GitHub Issue
Related Jira Key
Motivation and Context
Decouple build/checkout from branch to make release process simpler
How Has This Been Tested?
CI
Types of changes
Checklist: