Feature/mosaic carla sumo ambassadors #17
Conversation
co-simulation tool/README.md
Outdated
|
|
||
| For a successful running of the co-simulation tool, the following software must be installed: | ||
|
|
||
| - CARLA simulator |
There was a problem hiding this comment.
Does CARLA version need to be addressed? I believe this co-simulation tool does not support all CARLA version.
There was a problem hiding this comment.
CARLA version 0.9.10 was added in the README.md.
There was a problem hiding this comment.
Is it only support CARLA 0.9.10 or it just need the CARLA start script?
There was a problem hiding this comment.
It needs CARLA start script and CARLA python API library .egg. We tested CARLA 0.9.10, 0.9.10.1, and 0.9.11. Since you asked us to use CARLA 0.9.10, the default CARLA python API library .egg is for CARLA 0.9.10 and the users should use CARLA 0.9.10..
co-simulation tool/README.md
Outdated
|
|
||
| The co-simulation tool has been built successfully on different Operating Systems (OS). The building results are shown in the following table. | ||
|
|
||
| | Test NO. | OS | OS Version | Java JDK | Maven | SUMO | Building Results | |
There was a problem hiding this comment.
Please add the testing CARLA version in the form.
There was a problem hiding this comment.
When building the bundle file of co-simulation tool from the source code, CARLA is not needed.
There was a problem hiding this comment.
If the build package is not tested in the environment you mentioned in this form, please do not include this form here. Building successfully does not mean running successfully. It is confusing.
There was a problem hiding this comment.
The form has been removed from README.md.
co-simulation tool/README.md
Outdated
| mvn clean install -DskipTests | ||
| ``` | ||
|
|
||
| - After building, go to bundle\target directory, a zip file of co-simulation bundle can be found. |
There was a problem hiding this comment.
The name of "a zip file of co-simulation bundle" is still "eclipse-mosaic-21.1-SNAPSHOT". Can we change the name to something like "co-simulation" and specify the name here.
There was a problem hiding this comment.
The version "21.1-SNAPSHOT" has been changed to "1.0". The name of bundle "eclipse-mosaic-21.1-SNAPSHOT" has been changed to "carla-sumo-mosaic-1.0". The bundle name was updated in the README.md.
co-simulation tool/README.md
Outdated
|
|
||
| ## **Folder Content** | ||
|
|
||
| The folder structure of co-simulation tool is described in the following. |
There was a problem hiding this comment.
Specify the name of the folder here. It is confusing that which is the folder of co-simulation tool.
There was a problem hiding this comment.
The folder name cosimulation-root has been added in the README.md.
| print(message) | ||
|
|
||
| # Send V2x message to CARLA ambassador | ||
| if self.sendV2xInterval == 10: |
There was a problem hiding this comment.
What's the meaning of interval equals to 10 here? Is that necessary to be a fix number?
There was a problem hiding this comment.
Here 10 means every 10 time-step. I assume that CARLA vehicles send V2X messages every 10 time steps. It can be set as any integer depending on users needs.
|
|
||
| addEvent(event); | ||
| // Send received externalV2xMessage to the corresponding ambassador |
There was a problem hiding this comment.
Is there any chance that the receiver name will not be "carma","carla" and "rsu"? if so, could you add else function add the end to deal with the exception?
There was a problem hiding this comment.
Yes. The receiver may be SUMO vehicles. We do not need to send V2X messages to SUMO ambassador and then send V2X messages to SUMO federate. An else statement to log info has been added. In addition, there is no exception here.
| .getUnitFromId(v2xMessageAcknowledgement.getSourceName()); | ||
| // we don't simulate vehicles without an application | ||
| if (simulationUnit == null) { | ||
| return; |
There was a problem hiding this comment.
It is better to add log info as what you did in the line 618 and will also be better to apply for line 650 and 664
There was a problem hiding this comment.
The log info have been added in line 599, 650, and 664.
| * @param surroundingVehiclesRadius The radius around the ego vehicle for which | ||
| * vehicle data is to be sent. | ||
| * @param vehicleTypeId Id of the vehicle type. | ||
| * @param vehicleDeparture Vehicle departure information. |
There was a problem hiding this comment.
Could you provide more information about this parameter, such as in what situation this parameter will be used.
There was a problem hiding this comment.
VehicleDeparture provides the information about vehicle initialization. For example, when you spawn a CARMA vehicle in co-simulation tool, you need to provide the vehicle departure information such as the route ID, lane number, the position on the lane, the departure speed, i.e., where the vehicle will be spawned and what is the departure speed, etc.
NS3-Integration Dockerfile
| @@ -0,0 +1,222 @@ | |||
| # Running CARLA-SUMO-MOSAIC Co-Simulation Tool with NS-3 Integration in Docker | |||
There was a problem hiding this comment.
It is better to change the name of this user guide to README.md then Github will directly show the content in the page.
There was a problem hiding this comment.
The user guide has been renamed as README.md.
| ##### Step 1: Run the following command to build the docker image | ||
|
|
||
| ``` | ||
| docker build - < Dockerfile -t ns3-integration |
There was a problem hiding this comment.
ns3-integration should be changed to ns-3-integration
There was a problem hiding this comment.
ns3-integration has been changed to ns-3-integration.
|
|
||
| if response != command: | ||
| raise FatalTraCIError("Received answer %s for command %s." % (response, command)) | ||
| return result.readStringList() |
There was a problem hiding this comment.
Probably adding one more tab here. Return method in the viewing mode is inside of condition method. Try to put that outside of condition method
There was a problem hiding this comment.
The statement has been indented as suggested.
|
|
||
| (If you see a message `vim: command not found`, please use `sudo apt-get install vim` to install vim as text editor) | ||
|
|
||
| In line 365, change |
There was a problem hiding this comment.
It seems like not in the exactly line 365 from my side. Could you please double check about this part?
There was a problem hiding this comment.
The location has been specified in the user guide.
PR Details
Description
The folder co-simulation tool contains the source code of CARLA-SUMO-MOSAIC integration. It integrates CARLA and SUMO with Eclipse MOSAIC framework.
Related Issue
This is the source code of CARLA-SUMO-MOSAIC integration.
Motivation and Context
How Has This Been Tested?
There is a test folder in the source code.
Types of changes
Checklist:
CARMA Contributing Guide
PR Details
Description
The folder co-simulation tool contains the source code of CARLA-SUMO-MOSAIC integration. It integrates CARLA and SUMO with Eclipse MOSAIC framework.
Related Issue
This is the source code of CARLA-SUMO-MOSAIC integration.
Motivation and Context
How Has This Been Tested?
There is a test folder in the source code.
Types of changes
Checklist:
CARMA Contributing Guide