New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address ci fail #454

Merged

dan-du-car merged 1 commit into release/1_2_3 from hotfix_unit_test_cases

Nov 16, 2021

Contributor

dan-du-car commented Nov 16, 2021 •

edited

Loading

PR Details

Description

A unit test case failed that cause CI build failure.

Related Issue

NA

Motivation and Context

Release 1.2.3

How Has This Been Tested?

Local unit testing

Types of changes

Defect fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that cause existing functionality to change)

Checklist:

I have added any new packages to the sonar-scanner.properties file
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
ODE Contributing Guide
I have added tests to cover my changes.
All new and existing tests passed.


          address ci fail

589080d

dan-du-car changed the base branch from dev to release/1_2_3

November 16, 2021 02:24

dan-du-car requested a review from TonyEnglish

November 16, 2021 02:29

TonyEnglish approved these changes

View reviewed changes

Contributor

TonyEnglish left a comment

Thank you!

dan-du-car merged commit 72a05e8 into release/1_2_3

dan-du-car deleted the hotfix_unit_test_cases branch

November 16, 2021 02:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet