Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/gson removal #461

Merged
merged 2 commits into from
Dec 17, 2021
Merged

Bug/gson removal #461

merged 2 commits into from
Dec 17, 2021

Conversation

payneBrandon
Copy link
Collaborator

PR Details

Description

After migrating away from Gson in the previous PR, it was noted that the Gson reference was still in the code base. This PR removes that and updates the one remaining file (OdeTravelerInformationMessage.java) which still had Gson references.

This PR also removes the single remaining usage of log4j. The ODE has previously migrated to use logback with a default static instance. There was one remaining class using the old log4j, as well as the pom.xml import. Both have been updated.

Related Issue

Motivation and Context

Code cleanup for more concise usage and more consistent development going forward.

How Has This Been Tested?

Tested locally.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    ODE Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@payneBrandon payneBrandon marked this pull request as ready for review December 15, 2021 21:33
Copy link
Contributor

@TonyEnglish TonyEnglish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@dan-du-car dan-du-car merged commit 8c2708b into usdot-jpo-ode:dev Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants