New TIM Deposit Test, Fixed Failing Json Test & Log Level Review

[dmccoystephenson]

PR Details

Description

A unit test for the TimDepositController class for depositing a TIM with extra properties has been added to TimDepositControllerTest.java.

Additionally, a failing test involving invalid json syntax has been fixed by modifying the input json string.

Reviewed specified log levels for each log statement. In cases where another log level was more fitting, the log level being used was switched.

Related Issue

No related issue.

Motivation and Context

The new unit test was requested in #500.

The motivation for the logging changes is to ensure that we aren't logging messages unnecessarily and that we are logging messages correctly when we are on a particular log level.

How Has This Been Tested?

The unit tests ran and passed.

Types of changes

• Defect fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that cause existing functionality to change)
• Logging

Checklist:

• I have added any new packages to the sonar-scanner.properties file
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
  ODE Contributing Guide
• I have added tests to cover my changes.
• All new and existing tests passed.