-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master Update Submodules #516
Conversation
@TonyEnglish @Michael7371 Discovered issue with this fork. Was able to build docker images successfully by using git clone --recurse-submodules but ran into issue running kafka container from docker compose. Issue is related to https://github.com/Michael7371/jpo-ode/blob/47d21847a2f087545d7e9ff367e70b07478c881a/docker-compose.yml#L37 Kafka container fails to start with the following docker compose error :
After removing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment about docker-compose.yml and .env file
… set the default value to empty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@SaikrishnaBairamoni looks like there is a missing SONAR TOKEN. Are you working on this? |
No, this is probably a Sai thing.
From: paulbourelly999 ***@***.***>
Sent: Monday, August 28, 2023 7:10 AM
To: usdot-jpo-ode/jpo-ode ***@***.***>
Cc: Tony English ***@***.***>; Mention ***@***.***>
Subject: Re: [usdot-jpo-ode/jpo-ode] Master Update Submodules (PR #516)
@SaikrishnaBairamoni<https://github.com/SaikrishnaBairamoni> looks like there is a missing SONAR TOKEN. Are you working on this?
—
Reply to this email directly, view it on GitHub<#516 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEBI3YXOWHIQ4BZCI7B45K3XXSKCRANCNFSM6AAAAAA3DBOZE4>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
I've updated the SONAR_TOKEN with new one but seems like its failing due to the sonar cloud organization name in pom.xml |
@SaikrishnaBairamoni I think I have that updated now, I also pushed that update to the dev pr. |
@Michael7371 Sorry for the inconvenience we have duplicate sonar cloud organization which is usdot-jpo-ode-1 and there is already old account usdot-jpo-ode. we decided to go with old organization and remove the duplicate. we need to point back Pom.xml file changes from usdot-jpo-ode-1 to usdot-jpo-ode and in ci.yml as below mvn -e -X clean org.jacoco:jacoco-maven-plugin:prepare-agent package sonar:sonar -Dsonar.projectKey=usdot.jpo.ode:jpo-ode -Dsonar.projectName=jpo-ode -Dsonar.organization=usdot-jpo-ode -Dsonar.host.url=https://sonarcloud.io -Dsonar.branch.name=$GITHUB_REF_NAME |
@SaikrishnaBairamoni Okay that should be updated now. |
@SaikrishnaBairamoni I am not able to merge this PR. Could you give me privileges |
PR Details
Description
Updating submodules using this command: git submodule update --remote --merge
Related Issue
N/A
Motivation and Context
Includes many changes, one of which is that this commit includes the J2735 ASN file. Also noticed that many other modules were out of date.
How Has This Been Tested?
The submodules updated have already been thoroughly tested, this just updates the reference to those modules.
Types of changes
Checklist:
ODE Contributing Guide