Skip to content
This repository has been archived by the owner on Apr 24, 2019. It is now read-only.

Use INIT logo for tiles and icons (targets #104) #105

Closed
wants to merge 1 commit into from
Closed

Conversation

anselmh
Copy link
Member

@anselmh anselmh commented Mar 25, 2014

No description provided.

@alrra alrra added this to the v1.2.0 milestone Mar 26, 2014
@alrra
Copy link
Member

alrra commented Mar 26, 2014

@anselmh

  1. We should stick to a 32×32px favicon (see: HiDPI (32x32px) favicon.ico h5bp/html5-boilerplate#1285, HiDPI (32x32px) favicon.ico - Issue #1285 h5bp/html5-boilerplate#1286)

  2. Maybe have only the init logo in tile.png (same as in apple-touch-icon-precomposed.png)? I personally think it would look better.

@anselmh
Copy link
Member Author

anselmh commented Mar 26, 2014

Updated the Pull Request according to the comments.

@alrra
Copy link
Member

alrra commented Mar 26, 2014

Updated the Pull Request according to the comments.

👍

@anselmh

  1. Any reason why you also changed the tile-wide.png? I personally think it looked better the way it was. :)

  2. Why not use just one 32×32px icon for the favicon? Browsers automatically resize the favicon + adding both the 16×16px and 32×32px icons increases the size, which, considering that in some cases (the favicon is not cached + gzip is not enabled) the /favicon.ico maybe be request with every page load, is IMHO not the optimal default.

@anselmh
Copy link
Member Author

anselmh commented Mar 26, 2014

  1. Ah, thought you meant both tiles ;)
  2. Urm, it now should be a 32px favicon only.

@drublic
Copy link
Member

drublic commented Mar 30, 2014

@anselmh The favicon is at 16x16px in this PR. Can you please update it?

@anselmh
Copy link
Member Author

anselmh commented Mar 30, 2014

Are you sure? My system says it’s 32x32 and everything is pushed… maybe gh has an issue updating the ico file preview after force push?

@alrra
Copy link
Member

alrra commented Mar 30, 2014

@anselmh The favicon is at 16x16px in this PR

@drublic currently the favicon.ico contains 2 icons: a 16×16px and a 32×32px (and maybe that's why the GitHub UI also fails)

screen shot 2014-03-30 at 13 42 52

@anselmh
Copy link
Member Author

anselmh commented Mar 30, 2014

Uh, now I understand… didn’t knew an ico container could contain more than one image. If someone wants to jump in and fix it, go ahead. I’m not sure I have time to do it today…

@alrra
Copy link
Member

alrra commented Mar 30, 2014

If someone wants to jump in and fix it, go ahead. I’m not sure I have time to do it today…

@anselmh sure, will update it later.

@anselmh @drublic should the tile-wide.png contain also the init text, or do you prefer to leave it as it is right now ?

@drublic
Copy link
Member

drublic commented Mar 30, 2014

Cool, thanks @alrra. You can add the text if you want in tile-wide.png. I like it.

anselmh added a commit that referenced this pull request Mar 30, 2014
@alrra
Copy link
Member

alrra commented Mar 30, 2014

@anselmh @drublic done :)

anselmh added a commit that referenced this pull request Mar 30, 2014
@drublic
Copy link
Member

drublic commented Mar 30, 2014

Thanks. Merged the work in 470a5bb.

@drublic drublic closed this Mar 30, 2014
@drublic drublic deleted the ft-icons branch March 30, 2014 16:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants