Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode new ink! events with signature topic #1184

Merged
merged 15 commits into from
Sep 11, 2023
Merged

Decode new ink! events with signature topic #1184

merged 15 commits into from
Sep 11, 2023

Conversation

ascjones
Copy link
Collaborator

@ascjones ascjones commented Jun 28, 2023

Events are identified using the signature topic rather than the first byte.

Companion for use-ink/ink#1827

Changes to the decode command: added the --signature-topic argument for decoding events, which is not required for message and constructor, so I split the decode types into their own subcommands e.g. cargo contract decode event --signature-topic and cargo contract decode message

@ascjones ascjones mentioned this pull request Jun 30, 2023
@ascjones ascjones marked this pull request as ready for review September 11, 2023 10:00
Copy link
Contributor

@SkymanOne SkymanOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ascjones ascjones merged commit 9a67ad4 into master Sep 11, 2023
10 checks passed
@ascjones ascjones deleted the aj/events-2 branch September 11, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants