Validate externally passed Rust toolchain identifiers #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmichi
force-pushed
the
cmichi-validate-toolchain-names-for-cargo-verify
branch
from
6b49830
to
f3b868d
Compare
cmichi
force-pushed
the
cmichi-validate-toolchain-names-for-cargo-verify
branch
from
f3b868d
to
5e6a44e
Compare
ascjones
approved these changes
Nov 19, 2024
cmichi
added a commit
that referenced
this pull request
Nov 20, 2024
* Validate toolchains passed from external are valid * Improve user output formatting * Update changelog
Merged
cmichi
added a commit
that referenced
this pull request
Nov 20, 2024
* Handle case of Rust 1.79 behavior of stringify! on crate path (#1821) * Handle case of Rust 1.79 behavior of `stringify!` on crate path * Update changelog * Simplify code following Andrew's suggestion * Update crates/cargo-contract/src/cmd/config.rs Co-authored-by: Andrew Jones <ascjones@gmail.com> --------- Co-authored-by: Andrew Jones <ascjones@gmail.com> * Validate externally passed Rust toolchain identifiers (#1817) * Validate toolchains passed from external are valid * Improve user output formatting * Update changelog * For contract verification: don't rely on Wasm hash in metadata (#1820) * For contract verification: don't rely on Wasm hash in metadata * Improve user output * Check if reference contract `source.hash` matches `hash(source.wasm)` * Adapt existing test to new user output format * Update changelog * Apply `cargo fmt` * Update changelog * Bump versions * Execute `cargo update` * Update codeowners (#1787) * Make `clippy` happy * Apply `cargo fmt` --------- Co-authored-by: Andrew Jones <ascjones@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the new output formatting looks:
I did a drive-by improvement of the output format of
cargo-contractversion mismatches: