Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarification for [Wrapper for Traits] section #188

Merged
merged 9 commits into from
Apr 6, 2023

Conversation

SkymanOne
Copy link
Contributor

No description provided.

@SkymanOne SkymanOne requested a review from cmichi March 14, 2023 15:26
The wrapper is an attribute macro for traits that can be used to automatically generate
a callable `{Contract}Ref` implementation.

The benefits of such mechanism is a functional polymorphism.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But don't you also have that with our add-contract-as-dependency mechanism?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's exactly the point of this wrapper feature: no need to add another contract as a dependency

German and others added 5 commits March 20, 2023 16:19
Co-authored-by: Michael Müller <michi@parity.io>
Co-authored-by: Michael Müller <michi@parity.io>
Co-authored-by: Michael Müller <michi@parity.io>
Co-authored-by: Michael Müller <michi@parity.io>
Co-authored-by: Michael Müller <michi@parity.io>
docs/third-party-tools/openbrush.md Outdated Show resolved Hide resolved
docs/third-party-tools/openbrush.md Outdated Show resolved Hide resolved
docs/third-party-tools/openbrush.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@cmichi cmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cmichi cmichi merged commit 69db247 into master Apr 6, 2023
@cmichi cmichi deleted the gn/wrapper-clarification branch April 6, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants