feat: use checked arithmetic in vesting contract #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xf333
force-pushed
the
0xf333/improve_vesting_contract
branch
2 times, most recently
from
988dce8
to
3f1656a
Compare
ascjones
reviewed
Sep 6, 2023
There was a problem hiding this comment.
In general I would avoid mapping to generic error variants for the arithmetic errors, and prefer enforcing the invariants which prevent the arithmetic errors in the first place. In most cases you can then just panic via expect or unwrap. In other cases you can use specific errors. IMO Error variants should be used for specific error cases that are descriptive and possibly can be handled via a client.
I've highlighted a couple of places where the improvements could be made.
0xf333
added a commit
to 0xf333/ink-examples
that referenced
this pull request
Sep 11, 2023
Description ============ - Introduced enhanced error handling. - Introduced checked arithmetic for safer calculations. Impact ====== This commit addresses issue use-ink#36 * fix: Implement changes based on PR feedback feedback link: use-ink#40 (review)
0xf333
force-pushed
the
0xf333/improve_vesting_contract
branch
from
3f1656a
to
ea2efed
Compare
0xf333
added a commit
to 0xf333/ink-examples
that referenced
this pull request
Sep 11, 2023
Description ============ - Introduced enhanced error handling. - Introduced checked arithmetic for safer calculations. Impact ====== This commit addresses issue use-ink#36 * fix: Implement changes based on PR feedback feedback link: use-ink#40 (review)
0xf333
force-pushed
the
0xf333/improve_vesting_contract
branch
from
ea2efed
to
50d7a8a
Compare
Description ============ - Introduced enhanced error handling. - Introduced checked arithmetic for safer calculations. Impact ====== This commit addresses issue use-ink#36 * fix: Implement changes based on PR feedback feedback link: use-ink#40 (review)
0xf333
force-pushed
the
0xf333/improve_vesting_contract
branch
from
50d7a8a
to
1ec4142
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Impact
This PR addresses issue #36 and improves #34