-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove compile_as_dependency
config option
#1168
Conversation
Since we don't have any ink! attributes to affect the codegen anymore we can just inline the `cfg` blocks into the codegen
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑These are the results when building the
Link to the run | Last update: Tue Mar 8 05:34:10 CET 2022 |
Codecov Report
@@ Coverage Diff @@
## master #1168 +/- ##
==========================================
+ Coverage 78.46% 78.60% +0.13%
==========================================
Files 231 229 -2
Lines 8747 8715 -32
==========================================
- Hits 6863 6850 -13
+ Misses 1884 1865 -19
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR removes the
compile_as_dependency
configuration option on the mainink::contract
macro. The rational here is that this is an option which isn't reallyneeded/used and removing it simplifes the ink! language a bit.
This functionality isn't needed since we can achieve the same result with the
ink-as-dependency
crate feature.As an additional argument for removing it, quoting the old docs:
This was split out from #1163.