Polished refactor for constructor return type #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkymanOne
requested review from
cmichi,
ascjones and
HCastano
as code owners
ascjones
approved these changes
Nov 16, 2022
| #constructor_info ::Error | ||
| > | ||
| >( | ||
| "core::result::Result" |
There was a problem hiding this comment.
I'm not sure of the value of adding this to the display name...really we would want the generic parameters e.g. Result<(), MyError>. I know that is slightly tricky but not impossible. The other way would be to just have no display name, anyway the UI should detect whether we are dealing with a result using the type definition.
Anyway, leave it and I can always modify that in my PR
HCastano
pushed a commit
that referenced
this pull request
Nov 17, 2022
* Remove unused trait `InitializerReturnType` * WIP experimenting with static constructor return types * WIP * WIP generating metadata at compile time * WIP using constructor result type * Use generated method for metadata * Generate constructor info using static types * WIP restoring dispatch * WIP adding metadata test to ui test * Fix match as_result * Attempt to infer result type * Constructor dispatch compiles, remove metadata syntax stuff * Fmt * Remove unnecessary braces * Fix up execution for results * Fix up tests * Remove printlns * Explicitly set reverted flag * ReturnTypeSpec accurately reflects ABI * Polished refactor for constructor return type (#1500) * revert instantiating when error * display name + correct return typ when Self * fix dereferencing issue * UI test error variant + cleanup * cargo fmt * cargo fmt * fix another reference issue * fix spec contract test Co-authored-by: Andrew Jones <ascjones@gmail.com> * explicit prelude + fixing test error messages (#1503) * Add constructor to ReturnFlags to not require Default trait impl * Only invoke return_value for fallible constructors * Add e2e fallible constructor value tests * Fmt * Add some reflection tests for constructors returning an error * Check reflection for return types in UI tests * Check reflection in example * Fmt * Add test for fallible constructor succeeding * Add test for fallible constructor failing * Remove unused message * Fully qualify Ok(()) Co-authored-by: German <german@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my iteration over #1491
ErrorvariantSelfandResult<Self>