Add #[ink(default)] attribute for constructors and messages
#1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kziemianek
requested review from
cmichi,
ascjones,
HCastano and
SkymanOne
as code owners
kziemianek
force-pushed
the
kz-default-attr
branch
from
e127de5
to
05bd2df
Compare
|
@HCastano i see you are takinkg a 👀 at this PR. A lot checks have failed because of:
It seems like a one time issue, do you have permission to retry checks ? |
cmichi
reviewed
Apr 12, 2023
cmichi
reviewed
Apr 12, 2023
HCastano
approved these changes
Apr 12, 2023
crates/metadata/src/specs.rs
Outdated
| @@ -498,6 +525,8 @@ pub struct MessageSpec<F: Form = MetaForm> { | |||
| return_type: ReturnTypeSpec<F>, | |||
| /// The message documentation. | |||
| docs: Vec<F::String>, | |||
| /// If the message is default | |||
There was a problem hiding this comment.
Suggested change
| /// If the message is default | |
| /// If the message is the default for off-chain consumers (e.g UIs). |
crates/metadata/src/specs.rs
Outdated
| @@ -275,6 +283,8 @@ pub struct ConstructorSpec<F: Form = MetaForm> { | |||
| pub return_type: ReturnTypeSpec<F>, | |||
| /// The deployment handler documentation. | |||
| pub docs: Vec<F::String>, | |||
| /// If the constructor is default | |||
There was a problem hiding this comment.
Suggested change
| /// If the constructor is default | |
| /// If the constructor is the default for off-chain consumers (e.g UIs). |
HCastano
reviewed
Apr 12, 2023
HCastano
changed the title
#[ink(default)] attribute for constructors and messages
Yes, I was waiting for approval before moving to downstream projects. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
defaultattribute for constructors and messages.defaultattribute is reflected in metadata so consuming services can for example determine which constructor/message should be selected by default.#1703