-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Salt
in code generation during build_create
#842
Merged
Robbepop
merged 9 commits into
use-ink:master
from
Supercolony-net:bugfix/salt-compilation-error
Jul 13, 2021
Merged
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4ade565
Remove not used Salt
xgreenx 653ddd4
Merge branch 'paritytech:master' into bugfix/salt-compilation-error
xgreenx f5f783a
Updated unit test to cover case with code generation for trait.
xgreenx 28ccc13
Renamed seconds "new" constructor. Seems the same naming for construc…
xgreenx 619c480
Let's try to move trait definition into contract. Maybe it will resol…
xgreenx 57f1514
Moved trait implementation to separate test.
xgreenx d4bbc9a
Merge branch 'paritytech:master' into bugfix/salt-compilation-error
xgreenx fc598ad
Changed version of docker image to staging.
xgreenx e1f97da
Apply suggestions from code review
xgreenx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of doing this I would add a new UI test instead. This way we have the bug isolated