Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily remove codecov CI check #857

Merged
merged 2 commits into from
Jul 13, 2021

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Jul 13, 2021

  • There is some strange linker error in the master CI.
  • We can't reproduce it locally.
  • We suspect that it might have to do with an outdated docker image.
  • The failing master CI blocks publishing a new ink-ci-linux:production image.
  • The codecov check is broken since a few days anyway (due to some token issue). I created this ticket at the time: https://github.com/paritytech/ci_cd/issues/160.
  • We can bring the check back as soon as we sorted the linker error out in a PR.

@cmichi cmichi requested a review from HCastano July 13, 2021 14:38
Copy link
Contributor

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We suspect that it might have to do with an outdated docker image.

I was testing out the Docker images locally and I haven't found this to be the case. Running:

# On host machine
sudo docker run -it paritytech/ink-ci-linux:production

# In Docker container
git clone https://github.com/paritytech/ink/
cd ink && cargo test --verbose --all-features --no-fail-fast --workspace

Works just fine.

I'm thinking it's either something to do with the RUSTFLAGS, or maybe come caching issues on the runners.

Either way, Codecov is clearly broken right now, so yeah let's get this merged.

@HCastano HCastano added the A-CI Continuous integration work item label Jul 13, 2021
@HCastano HCastano merged commit 1ed7868 into master Jul 13, 2021
@HCastano HCastano deleted the cmichi-temporarily-disable-codecov-ci-check branch July 13, 2021 18:05
@TriplEight TriplEight mentioned this pull request Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI Continuous integration work item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants