Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print panic message to debug buffer #894

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Print panic message to debug buffer #894

merged 1 commit into from
Aug 16, 2021

Conversation

athei
Copy link
Contributor

@athei athei commented Aug 12, 2021

We should print panic messages to the debug buffer when logging is enabled. This will print useful messages to the console and UIs (once they implement it). It looks like this:

panicked at 'encountered error while querying transferred balance: Decode(Error)', /Users/alexander/Developer/parity/ink/crates/lang/src/dispatcher.rs:145:10

Before we consider merging this we must stabilize seal_debug_message.

Depends on: use-ink/cargo-contract#326

@athei athei requested a review from cmichi August 12, 2021 11:59
@cmichi
Copy link
Collaborator

cmichi commented Aug 12, 2021

@athei Is there anything left before we can stabilize seal_debug_message in the contracts pallet? From my POV it seems to be working well, I'm not aware of any issues with it.

@athei
Copy link
Contributor Author

athei commented Aug 12, 2021

I think it can be stabilized as is. I need to double check whether the weight stuff is sound, though.

Copy link
Collaborator

@cmichi cmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're waiting for the stabilization of seal_debug_message before merging. Code looks good.

@athei
Copy link
Contributor Author

athei commented Aug 12, 2021

@HCastano HCastano merged commit eabb117 into master Aug 16, 2021
@HCastano HCastano deleted the at-panic-message branch August 16, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants