Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SpreadLayout and StorageLayout derive macro hygiene #926

Merged
merged 2 commits into from
Sep 20, 2021

Conversation

Robbepop
Copy link
Collaborator

PR and side-work resulting from my work on https://github.com/paritytech/ink/pull/665/commits.

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2021

Codecov Report

Merging #926 (2672dd2) into master (4155ebe) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #926      +/-   ##
==========================================
+ Coverage   84.24%   84.49%   +0.24%     
==========================================
  Files         172      158      -14     
  Lines        7945     6551    -1394     
==========================================
- Hits         6693     5535    -1158     
+ Misses       1252     1016     -236     
Impacted Files Coverage Δ
crates/storage/derive/src/spread_layout.rs 98.48% <ø> (ø)
crates/storage/derive/src/storage_layout.rs 94.11% <100.00%> (ø)
crates/lang/ir/src/ir/item_impl/mod.rs 73.58% <0.00%> (-17.80%) ⬇️
crates/lang/codegen/src/generator/metadata.rs 90.90% <0.00%> (-6.70%) ⬇️
crates/lang/ir/src/ir/item_impl/impl_item.rs 51.35% <0.00%> (-6.10%) ⬇️
crates/lang/ir/src/ir/idents_lint.rs 68.42% <0.00%> (-3.01%) ⬇️
crates/lang/ir/src/ir/config.rs 88.88% <0.00%> (-2.61%) ⬇️
crates/lang/ir/src/ir/trait_def.rs 92.89% <0.00%> (-0.21%) ⬇️
crates/metadata/src/lib.rs 0.00% <0.00%> (ø)
crates/primitives/src/key_ptr.rs 100.00% <0.00%> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4155ebe...2672dd2. Read the comment docs.

@Robbepop Robbepop merged commit 9bab483 into master Sep 20, 2021
@Robbepop Robbepop deleted the robin-improve-derive-macro-hygiene branch September 20, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants