Check namespace argument is identifier #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # crates/lang/macro/tests/compile_tests.rs # crates/lang/macro/tests/ui/fail/N-01-namespace-invalid-identifier.rs # crates/lang/macro/tests/ui/fail/N-01-namespace-invalid-identifier.stderr # crates/lang/macro/tests/ui/fail/N-02-namespace-invalid-type.rs # crates/lang/macro/tests/ui/fail/N-02-namespace-invalid-type.stderr # crates/lang/macro/tests/ui/fail/N-03-namespace-missing-argument.rs # crates/lang/macro/tests/ui/fail/N-03-namespace-missing-argument.stderr
ascjones
reviewed
Sep 21, 2021
Codecov Report
@@ Coverage Diff @@
## master #931 +/- ##
==========================================
+ Coverage 86.17% 87.18% +1.01%
==========================================
Files 171 169 -2
Lines 7653 7556 -97
==========================================
- Hits 6595 6588 -7
+ Misses 1058 968 -90
Continue to review full report at Codecov.
|
ascjones
approved these changes
Sep 21, 2021
43 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just checks that
argumentin#[ink(namespace = "argument")]is a valid Rust identifier and adds tests for it.