Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor simplifications and code dupe reductions in codegen #938

Merged
merged 3 commits into from
Sep 23, 2021

Conversation

Robbepop
Copy link
Collaborator

Carved out work from #665.

@codecov-commenter
Copy link

Codecov Report

Merging #938 (02a940c) into master (882b4dd) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #938      +/-   ##
==========================================
- Coverage   82.84%   82.67%   -0.17%     
==========================================
  Files         177      177              
  Lines        8066     8058       -8     
==========================================
- Hits         6682     6662      -20     
- Misses       1384     1396      +12     
Impacted Files Coverage Δ
crates/lang/codegen/src/generator/item_impls.rs 98.92% <100.00%> (+4.63%) ⬆️
crates/lang/ir/src/ir/item_impl/callable.rs 93.75% <100.00%> (+0.27%) ⬆️
...tes/storage/src/collections/bitstash/fuzz_tests.rs 40.00% <0.00%> (-60.00%) ⬇️
...rates/storage/src/collections/binary_heap/tests.rs 90.00% <0.00%> (-1.43%) ⬇️
...ates/storage/src/collections/hashmap/fuzz_tests.rs 98.93% <0.00%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 882b4dd...02a940c. Read the comment docs.

@Robbepop Robbepop merged commit beaf989 into master Sep 23, 2021
@Robbepop Robbepop deleted the robin-minor-simplifications-in-codegen branch September 23, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants