Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Fix Docker deployment #1070

Merged
merged 2 commits into from
Nov 13, 2023
Merged

🔧 Fix Docker deployment #1070

merged 2 commits into from
Nov 13, 2023

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Nov 13, 2023

Fix the Docker build, which failed on the last deployment

Also

@chrisjsewell chrisjsewell changed the title 🔧 Fix docker deployment 🔧 Fix Docker deployment Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@f5fd092). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1070   +/-   ##
=========================================
  Coverage          ?   79.27%           
=========================================
  Files             ?       56           
  Lines             ?     6460           
  Branches          ?        0           
=========================================
  Hits              ?     5121           
  Misses            ?     1339           
  Partials          ?        0           
Flag Coverage Δ
pytests 79.27% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisjsewell chrisjsewell marked this pull request as ready for review November 13, 2023 19:13
Copy link
Member

@danwos danwos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 👍

@chrisjsewell chrisjsewell merged commit 6ffb097 into master Nov 13, 2023
19 checks passed
@chrisjsewell chrisjsewell deleted the fix-docker branch November 13, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants