Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom CA Certificate preference #1155

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

BrandonGillis
Copy link
Contributor

@BrandonGillis BrandonGillis commented Dec 6, 2023

Description

UI changes :

Animation

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@BrandonGillis
Copy link
Contributor Author

Any review about this MR ? :)

@salarshad
Copy link

Hi Brandon, thank you for this update. Hope it gets approved.

Can we modify this option so that it is available separately per collection (if not for each request)?

Just one global ca is not very user-friendly. For example, as a freelancer developer I have to code for multiple clients each having their own ca.

@helloanoop helloanoop merged commit 2608ec0 into usebruno:main Jan 4, 2024
2 checks passed
@helloanoop
Copy link
Contributor

Fantastic work @BrandonGillis ! 👏👏 Merged !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants