Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add authorization token to generate code #1792

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

leoferreiralima
Copy link
Contributor

Fixes #1791

Description

This PR add to Bruno the ability of generate code with Authorization headers of basic and bearer mode

bruno-auth-token-fix

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@leobenkel
Copy link

thank you. this feature is missing

@varunvora
Copy link

Thank you! I hope this gets merged soon.

@leoferreiralima
Copy link
Contributor Author

@varunvora @sanjai0py changes are done, do you can review? to see if something is missing

@varunvora
Copy link

Looks good! Thanks so much for this. @sanjai0py can we have this merged soon?

@leoferreiralima
Copy link
Contributor Author

Looks good! Thanks so much for this. @sanjai0py can we have this merged soon?

You are welcome!

@hungdh0x5e
Copy link

+1
I really need this feature

@Moribund7
Copy link

@sanjai0py do you have any updates regarding this one? Could it be merged?

@Moribund7
Copy link

@varunvora do you know who from the maintainers could approve the workflow run?

@Moribund7
Copy link

@helloanoop could you please check and advice who could help with approving this?

@fritz-trawa
Copy link

fritz-trawa commented May 31, 2024

@helloanoop do you need help looking after this repo?

@Moribund7
Copy link

@leoferreiralima could you merge this one?

@Moribund7
Copy link

Or @varunvora do you have permissions to merge this one?

@leoferreiralima
Copy link
Contributor Author

@leoferreiralima could you merge this one?

i don't have permission to do that. We have to wait the maintainers merge it

import get from 'lodash/get';

export const getAuthHeaders = (collectionRootAuth, requestAuth) => {
const auth = collectionRootAuth && ['inherit', 'none'].includes(requestAuth.mode) ? collectionRootAuth : requestAuth;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might want to remove 'none' from the array

@helloanoop helloanoop merged commit a0df513 into usebruno:main Jun 19, 2024
@helloanoop
Copy link
Contributor

Merged!

Thanks for working on this @leoferreiralima !
Appreciate everyone's patience on the delayed merge.

@leoferreiralima
Copy link
Contributor Author

Thanks @helloanoop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic and Bearer Token is not exported with gerate code
9 participants