-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add authorization token to generate code #1792
fix: add authorization token to generate code #1792
Conversation
thank you. this feature is missing |
.../components/Sidebar/Collections/Collection/CollectionItem/GenerateCodeItem/CodeView/index.js
Outdated
Show resolved
Hide resolved
Thank you! I hope this gets merged soon. |
67eec72
to
5d73ff1
Compare
@varunvora @sanjai0py changes are done, do you can review? to see if something is missing |
Looks good! Thanks so much for this. @sanjai0py can we have this merged soon? |
You are welcome! |
5d73ff1
to
3ce55dc
Compare
+1 |
@sanjai0py do you have any updates regarding this one? Could it be merged? |
@varunvora do you know who from the maintainers could approve the workflow run? |
@helloanoop could you please check and advice who could help with approving this? |
@helloanoop do you need help looking after this repo? |
@leoferreiralima could you merge this one? |
Or @varunvora do you have permissions to merge this one? |
i don't have permission to do that. We have to wait the maintainers merge it |
import get from 'lodash/get'; | ||
|
||
export const getAuthHeaders = (collectionRootAuth, requestAuth) => { | ||
const auth = collectionRootAuth && ['inherit', 'none'].includes(requestAuth.mode) ? collectionRootAuth : requestAuth; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might want to remove 'none' from the array
Merged! Thanks for working on this @leoferreiralima ! |
Thanks @helloanoop |
Fixes #1791
Description
This PR add to Bruno the ability of generate code with Authorization headers of basic and bearer mode
Contribution Checklist: