Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): Display all contracts in a package in deployments tab #1354

Merged
merged 9 commits into from
Sep 8, 2024

Conversation

FuzzB0t
Copy link
Contributor

@FuzzB0t FuzzB0t commented Sep 4, 2024

https://www.loom.com/share/74000c82035b479baa3d79bbcc1b3fe5

Also added search bar:
https://www.loom.com/share/ae9a2cc03b2d4de1b44e549ed9c52e3a

The search bar above enables searching for any value under each column, so Operations, contract names and addresses, as well as specific transaction hashes.

Also fixes a bug where if a package has a run step in its definition it would break the site

Example: https://usecannon.com/packages/synthetix/2/1-main

fixes https://linear.app/usecannon/issue/CAN-472/show-any-contracts-that-are-deployed-on-contract-page-front

Copy link

changeset-bot bot commented Sep 4, 2024

⚠️ No Changeset found

Latest commit: 8b5e2c1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@nicosampler nicosampler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some suggestions:

  1. We could make the search case-insensitive
image image
  1. Let's place the searchbar at the left.

  2. Let's also add a searchbar for functions and events. Or perhaps we can use the same serachbar to filter all the sections.

Copy link
Contributor

@nicosampler nicosampler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@FuzzB0t FuzzB0t merged commit 1ca421b into main Sep 8, 2024
6 of 8 checks passed
@FuzzB0t FuzzB0t deleted the display-all-contracts branch September 8, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants