Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(builder): error when a dependency input cannot be found. #1360

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

dbeal-eth
Copy link
Contributor

@dbeal-eth dbeal-eth commented Sep 7, 2024

explicit dependency enforcement will significantly reduce the chance of typos or other mistake leading to unexpected empty values.

does not affect dependency packages or anything thats pulled in thats already on the registry, so minimizes unnecessary breakage.

fixes https://linear.app/usecannon/issue/CAN-509/check-templating-input-values-and-throw-an-error-on-typos

explicit dependency enforcement will significantly reduce the chance of
typos or other mistake leading to unexpected empty values.
@dbeal-eth dbeal-eth added the enhancement New feature or request label Sep 7, 2024
@dbeal-eth dbeal-eth self-assigned this Sep 7, 2024
Copy link

changeset-bot bot commented Sep 7, 2024

⚠️ No Changeset found

Latest commit: c377aec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mjlescano mjlescano changed the base branch from main to dev September 16, 2024 14:48
@dbeal-eth dbeal-eth enabled auto-merge (squash) September 16, 2024 17:45
@dbeal-eth dbeal-eth changed the title error when a dependency input cannot be found. feat(builder): error when a dependency input cannot be found. Sep 16, 2024
@mjlescano mjlescano disabled auto-merge September 16, 2024 18:25
@mjlescano mjlescano enabled auto-merge (squash) September 16, 2024 18:27
@mjlescano mjlescano merged commit 5960680 into dev Sep 16, 2024
6 of 8 checks passed
@mjlescano mjlescano deleted the feat-necessary-deps branch September 16, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants