Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builder): ctx timestamp type #1383

Merged
merged 4 commits into from
Sep 17, 2024
Merged

fix(builder): ctx timestamp type #1383

merged 4 commits into from
Sep 17, 2024

Conversation

mjlescano
Copy link
Member

Closes https://linear.app/usecannon/issue/CAN-538/on-cannonfiles-the-timestamp-variable-should-be-of-type-number

This PR fixes the necessity on having to cast the timestamp variable to number on cannonfiles on cases like this one:
Screenshot_2024-09-16_at_3 42 59_PM

Copy link

changeset-bot bot commented Sep 17, 2024

⚠️ No Changeset found

Latest commit: 30ae92b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@dbeal-eth dbeal-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok

@mjlescano mjlescano merged commit 2814127 into dev Sep 17, 2024
6 of 8 checks passed
@mjlescano mjlescano deleted the fix/can-538-timestamp-type branch September 17, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants