fix(buidler): foundry build issues #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also significanlty improves the speed by removing calls to foundry commands. Warp speed. also fix number of constructor arguments not being checked for contract deployment (tbh surprised viem doesn't do this automatically but whateves)
|
dbeal-eth
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/usecannon/issue/CAN-512/contract-fully-qualified-names-do-not-work-when-using-the-cli-forge
PR with fixed branch name of #1435
also significanlty improves the speed by removing calls to foundry commands. Warp speed.
also fix number of constructor arguments not being checked for contract deployment (tbh surprised viem doesn't do this automatically but whateves)