Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Check forge ast support #792

Merged
merged 3 commits into from
Feb 28, 2024
Merged

fix(cli): Check forge ast support #792

merged 3 commits into from
Feb 28, 2024

Conversation

saeta-eth
Copy link
Contributor

This PR aims to address an error that occurred when installing the latest Foundry version. The cannon build command is broken in Foundry projects since Forge decided to remove the AST from the artifacts by default in this PR: foundry-rs/foundry#7197. Now, you need to explicitly add the --ast flag if you want to include them.

Copy link

changeset-bot bot commented Feb 27, 2024

⚠️ No Changeset found

Latest commit: 5692632

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Feb 27, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5692632. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Co-authored-by: Matías Lescano <mjlescano@users.noreply.github.com>
@saeta-eth saeta-eth merged commit 425b571 into main Feb 28, 2024
7 of 9 checks passed
@saeta-eth saeta-eth deleted the fix/forge-build-ast branch February 28, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants