Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffered insert at capacity fails to insert in Sqlite #132

Closed
dannyvankooten opened this issue Sep 21, 2018 · 1 comment
Closed

Buffered insert at capacity fails to insert in Sqlite #132

dannyvankooten opened this issue Sep 21, 2018 · 1 comment
Labels

Comments

@dannyvankooten
Copy link
Contributor

Because of SQLITE_MAX_VARIABLE_NUMBER, which defaults to 999.

@dannyvankooten
Copy link
Contributor Author

With 10 columns per (pageview) row, this means we can insert 99 rows at most when using SQLite with default settings.

d116f1f changes the buffer capacity to 90 so we stay clear of this limit.

Alternatively we may still use a higher buffer cap for PostgreSQL or MySQL powered Fathom instances, but I feel a 90 row insert is probably a sensible choice for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant