Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS errors with appendChild and removeChild #165

Closed
msencenb opened this issue Oct 18, 2018 · 2 comments
Closed

JS errors with appendChild and removeChild #165

msencenb opened this issue Oct 18, 2018 · 2 comments
Labels
bug

Comments

@msencenb
Copy link

This bug seems to be happening occasionally in my app, but not always, as I have data in my fathom dashboard. Using the hosted fathom pro service, here's a screenshot from my local environment:

image
dannyvankooten added a commit that referenced this issue Oct 19, 2018
@dannyvankooten
wait for document.body to load before appending tracking img, #165
22121a8
@dannyvankooten
Copy link
Contributor

dannyvankooten commented Oct 19, 2018 •
edited
Loading

Hey @msencenb,

Great catch!

Did you add the tracking snippet to your <head> section or near the end of your HTML page?

My theory is that there is a race condition between the tracking script loading before your app has even initialized its document.body. 22121a8 should prevent that from happening, I'm updating everyone on our hosted offering as we speak.

Can you let me know if the issue persists?

@msencenb
Copy link
Author

Yes, you got it. Looks good now, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@msencenb @dannyvankooten