Adapt to GitHub's optimizations that prevented the script from detect…

…ing page changes

plugin/manifest.json

@@ -1,6 +1,6 @@
 {
   "name": "Useful Forks",
-  "version": "2.1",
+  "version": "2.2",
   "description": "To list GitHub forks ordered by stars, with additional information and automatic filtering of irrelevant ones.",
   "permissions": [
     "*://github.com/*"

plugin/useful-forks.js

@@ -4,16 +4,16 @@ function getRepoUrl() {
   return `https://useful-forks.github.io/?repo=${user}/${repo}`
 }
 
-function setBtnUrl(btnId) {
-  const button = document.getElementById(btnId);
+function setBtnUrl() {
+  const button = document.getElementById(UF_BTN_ID);
   button.addEventListener('click', () => {
     window.open(getRepoUrl(), '_blank');
   });
 }
 
-function setContent(li, btnId) {
+function setContent(li) {
   const content = `<div class="float-left">
-                     <button id="${btnId}" class="btn-sm btn">
+                     <button id="${UF_BTN_ID}" class="btn-sm btn">
                        <svg height="16" width="16" version="1.1" viewBox="0 0 183.79 183.79" class="octicon octicon-pin mr-1">
                          <path d="M54.734,9.053C39.12,18.067,27.95,32.624,23.284,50.039c-4.667,17.415-2.271,35.606,6.743,51.22 c12.023,20.823,34.441,33.759,58.508,33.759c7.599,0,15.139-1.308,22.287-3.818l30.364,52.592l21.65-12.5l-30.359-52.583 c10.255-8.774,17.638-20.411,21.207-33.73c4.666-17.415,2.27-35.605-6.744-51.22C134.918,12.936,112.499,0,88.433,0 C76.645,0,64.992,3.13,54.734,9.053z M125.29,46.259c5.676,9.831,7.184,21.285,4.246,32.25c-2.938,10.965-9.971,20.13-19.802,25.806 c-6.462,3.731-13.793,5.703-21.199,5.703c-15.163,0-29.286-8.146-36.857-21.259c-5.676-9.831-7.184-21.284-4.245-32.25 c2.938-10.965,9.971-20.13,19.802-25.807C73.696,26.972,81.027,25,88.433,25C103.597,25,117.719,33.146,125.29,46.259z"></path>
                        </svg>
@@ -24,15 +24,45 @@ function setContent(li, btnId) {
 }
 
 function init() {
+  // This is required for some cases like on Back/Forward navigation
+  const oldLi = document.getElementById(UF_LI_ID);
+  if (oldLi) {
+    oldLi.remove();
+  }
+
   const forkBtn = document.getElementById("fork-button");
   if (forkBtn) { // sufficient to know the user is looking at a repository
     const parentLi = forkBtn.closest("li");
     const newLi = document.createElement("li");
-    const btnId = "useful_forks_btn";
-    setContent(newLi, btnId);
+    newLi.id = UF_LI_ID
+    setContent(newLi);
     parentLi.parentNode.insertBefore(newLi, parentLi);
-    setBtnUrl(btnId);
+    setBtnUrl();
   }
 }
 
+const UF_LI_ID  = "useful_forks_li";
+const UF_BTN_ID = "useful_forks_btn";
 init(); // entry point of the script
+
+/*
+Without a timeout, the Back/Forward browser navigation ends up messing up
+the JavaScript onClick event assigned to the button.
+The trade-off here is that the button appears a bit after the page loads.
+
+Moreover, it's worth pointing out that a MutationObserver is required here
+because GitHub does some optimizations that do not require reloading an
+entire page.
+PJax is one of those tricks used, but it does not seem to be exclusive,
+hence why `document.addEventListener("pjax:end", init);` is not sufficient.
+*/
+let timeout;
+const observer = new MutationObserver(() => {
+  clearTimeout(timeout);
+  timeout = setTimeout(init, 10);
+});
+/*
+`subtree: false` is used to reduce the amount of callbacks triggered.
+`document.body` may be of narrower scope, but I couldn't figure it out.
+*/
+observer.observe(document.body, { childList: true, subtree: false });