Bump Ktlint to 0.49.1 #64

mateuszkwiecinski · 2023-04-21T20:08:00Z

No description provided.

github-actions · 2023-04-21T20:11:18Z

Diffuse output:

OLD: diffuse-base-file
NEW: ktlint-gradle-plugin.jar

       │            compressed            │           uncompressed           
       ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 JAR   │ old       │ new       │ diff     │ old       │ new       │ diff     
───────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
 class │ 125.1 KiB │ 126.4 KiB │ +1.3 KiB │ 249.9 KiB │ 254.5 KiB │ +4.7 KiB 
 other │     2 KiB │     2 KiB │      0 B │     508 B │     508 B │      0 B 
───────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
 total │ 127.1 KiB │ 128.5 KiB │ +1.3 KiB │ 250.4 KiB │   255 KiB │ +4.7 KiB 

 CLASSES │ old │ new │ diff          
─────────┼─────┼─────┼───────────────
 classes │  80 │  80 │   0 (+0 -0)   
 methods │ 639 │ 649 │ +10 (+59 -49) 
  fields │ 145 │ 155 │ +10 (+15 -5)

JAR

     compressed      │    uncompressed     │                                                                                           
──────────┬──────────┼──────────┬──────────┤                                                                                           
 size     │ diff     │ size     │ diff     │ path                                                                                      
──────────┼──────────┼──────────┼──────────┼───────────────────────────────────────────────────────────────────────────────────────────
  1.9 KiB │ +1.2 KiB │  4.1 KiB │ +3.3 KiB │ ∆ io/github/usefulness/tasks/workers/KtlintWorkerKt.class                                 
  1.6 KiB │   -438 B │  3.1 KiB │   -1 KiB │ ∆ io/github/usefulness/support/BaselineUtilsKt.class                                      
    893 B │   +253 B │  1.2 KiB │   +564 B │ ∆ io/github/usefulness/tasks/workers/ConsoleReportWorker_WhenMappings.class               
  3.8 KiB │   +157 B │  8.2 KiB │   +510 B │ ∆ io/github/usefulness/tasks/workers/ConsoleReportWorker.class                            
  4.4 KiB │   -102 B │ 10.4 KiB │   -183 B │ ∆ io/github/usefulness/tasks/workers/GenerateReportsWorker.class                          
  1.5 KiB │    +49 B │  2.9 KiB │   +259 B │ ∆ io/github/usefulness/support/RuleSetsKt_resolveRuleProviders__inlined_compareBy_1.class 
  3.8 KiB │    +46 B │  8.5 KiB │   +218 B │ ∆ io/github/usefulness/tasks/workers/KtlintWorker.class                                   
    646 B │    +24 B │    705 B │    +71 B │ ∆ io/github/usefulness/support/BaselineUtilsKt_WhenMappings.class                         
  1.1 KiB │    +24 B │  1.8 KiB │   +108 B │ ∆ io/github/usefulness/tasks/workers/KtlintWorker_execute_1.class                         
  1.4 KiB │    +23 B │  2.9 KiB │   +112 B │ ∆ io/github/usefulness/support/RuleSetsKt.class                                           
  1.1 KiB │    +23 B │  2.1 KiB │   +128 B │ ∆ io/github/usefulness/support/RuleSetsKt_resolveRuleProviders_2.class                    
  1.8 KiB │    -22 B │  3.8 KiB │    -94 B │ ∆ io/github/usefulness/support/KtlintErrorResult.class                                    
  2.3 KiB │    +22 B │    5 KiB │   +114 B │ ∆ io/github/usefulness/support/KtlintEngineUtilsKt.class                                  
  3.3 KiB │    +17 B │    7 KiB │   +116 B │ ∆ io/github/usefulness/support/ReporterTypeKt.class                                       
  1.3 KiB │    +14 B │  2.2 KiB │   +119 B │ ∆ io/github/usefulness/tasks/workers/KtlintWorker_execute_2_fixedContent_1.class          
  1.2 KiB │     +9 B │  2.3 KiB │    +84 B │ ∆ io/github/usefulness/support/EditorConfigUtilsKt_getPropertiesForDisabledRules_3.class  
  4.9 KiB │     +9 B │ 12.6 KiB │   +155 B │ ∆ io/github/usefulness/support/EditorConfigUtilsKt.class                                  
  1.1 KiB │     -8 B │  1.8 KiB │    +92 B │ ∆ io/github/usefulness/tasks/workers/KtlintWorker_execute_2_1.class                       
  1.4 KiB │     +7 B │  2.7 KiB │    +98 B │ ∆ io/github/usefulness/support/EditorConfigUtilsKt_getPropertiesForDisabledRules_2.class  
──────────┼──────────┼──────────┼──────────┼───────────────────────────────────────────────────────────────────────────────────────────
 39.4 KiB │ +1.3 KiB │ 83.2 KiB │ +4.7 KiB │ (total)

CLASSES

METHODS:

   old │ new │ diff          
  ─────┼─────┼───────────────
   639 │ 649 │ +10 (+59 -49) 
  + io.github.usefulness.support.EditorConfigUtilsKt buildEditorConfigDefaults(List) → EditorConfigDefaults
  + io.github.usefulness.support.EditorConfigUtilsKt buildEditorConfigOverride(List) → EditorConfigOverride
  + io.github.usefulness.support.EditorConfigUtilsKt editorConfigDefaults(boolean) → EditorConfigDefaults
  + io.github.usefulness.support.EditorConfigUtilsKt editorConfigOverride(List) → EditorConfigOverride
  + io.github.usefulness.support.EditorConfigUtilsKt_getPropertiesForDisabledRules_2 invoke(String) → EditorConfigProperty
  + io.github.usefulness.support.EditorConfigUtilsKt_getPropertiesForDisabledRules_3 invoke(EditorConfigProperty) → Pair
  + io.github.usefulness.support.KtlintEngineUtilsKt createKtlintEngine(List, boolean) → KtLintRuleEngine
  + io.github.usefulness.support.KtlintEngineUtilsKt resetEditorconfigCacheIfNeeded(KtLintRuleEngine, ConfigurableFileCollection, Logger)
  + io.github.usefulness.support.RuleSetsKt_resolveRuleProviders_2 invoke(RuleSetProviderV3) → Set
  + io.github.usefulness.tasks.workers.ConsoleReportWorker generateMessage(KtlintCliError, File, String) → String
  + io.github.usefulness.tasks.workers.KtlintWorker_execute_1 invoke(RuleProvider) → CharSequence
  + io.github.usefulness.tasks.workers.KtlintWorker_execute_2_1 invoke(LintError)
  + io.github.usefulness.tasks.workers.KtlintWorker_execute_2_fixedContent_1 invoke(LintError, boolean)
  + io.github.usefulness.tasks.workers.KtlintWorkerKt access_toKtlintCliErrorForFormat(LintError, boolean) → KtlintCliError
  + io.github.usefulness.tasks.workers.KtlintWorkerKt access_toKtlintCliErrorForLint(LintError) → KtlintCliError
  + io.github.usefulness.tasks.workers.KtlintWorkerKt toKtlintCliErrorForFormat(LintError, boolean) → KtlintCliError
  + io.github.usefulness.tasks.workers.KtlintWorkerKt toKtlintCliErrorForLint(LintError) → KtlintCliError
  + com.pinterest.ktlint.cli.reporter.baseline.Baseline getLintErrorsPerFile() → Map
  + com.pinterest.ktlint.cli.reporter.baseline.Baseline getStatus() → Baseline_Status
  + com.pinterest.ktlint.cli.reporter.baseline.Baseline_Status ordinal() → int
  + com.pinterest.ktlint.cli.reporter.baseline.Baseline_Status values() → Baseline_Status[]
  + com.pinterest.ktlint.cli.reporter.baseline.BaselineKt doesNotContain(List, KtlintCliError) → boolean
  + com.pinterest.ktlint.cli.reporter.baseline.BaselineKt loadBaseline(String) → Baseline
  + com.pinterest.ktlint.cli.reporter.core.api.KtlintCliError <init>(int, int, String, String, KtlintCliError_Status)
  + com.pinterest.ktlint.cli.reporter.core.api.KtlintCliError getCol() → int
  + com.pinterest.ktlint.cli.reporter.core.api.KtlintCliError getDetail() → String
  + com.pinterest.ktlint.cli.reporter.core.api.KtlintCliError getLine() → int
  + com.pinterest.ktlint.cli.reporter.core.api.KtlintCliError getRuleId() → String
  + com.pinterest.ktlint.cli.reporter.core.api.KtlintCliError getStatus() → KtlintCliError_Status
  + com.pinterest.ktlint.cli.reporter.core.api.KtlintCliError_Status ordinal() → int
  + com.pinterest.ktlint.cli.reporter.core.api.KtlintCliError_Status values() → KtlintCliError_Status[]
  + com.pinterest.ktlint.cli.reporter.core.api.ReporterProviderV2 get(PrintStream, Map) → ReporterV2
  + com.pinterest.ktlint.cli.reporter.core.api.ReporterProviderV2 getId() → String
  + com.pinterest.ktlint.cli.reporter.core.api.ReporterV2 after(String)
  + com.pinterest.ktlint.cli.reporter.core.api.ReporterV2 afterAll()
  + com.pinterest.ktlint.cli.reporter.core.api.ReporterV2 before(String)
  + com.pinterest.ktlint.cli.reporter.core.api.ReporterV2 beforeAll()
  + com.pinterest.ktlint.cli.reporter.core.api.ReporterV2 onLintError(String, KtlintCliError)
  + com.pinterest.ktlint.cli.ruleset.core.api.RuleSetProviderV3 getId-FcaicGg() → String
  + com.pinterest.ktlint.cli.ruleset.core.api.RuleSetProviderV3 getRuleProviders() → Set
  + com.pinterest.ktlint.rule.engine.api.Code_Companion fromFile(File) → Code
  + com.pinterest.ktlint.rule.engine.api.EditorConfigDefaults <init>(EditorConfig)
  + com.pinterest.ktlint.rule.engine.api.EditorConfigDefaults_Companion getEMPTY_EDITOR_CONFIG_DEFAULTS() → EditorConfigDefaults
  + com.pinterest.ktlint.rule.engine.api.EditorConfigOverride_Companion from(Pair[]) → EditorConfigOverride
  + com.pinterest.ktlint.rule.engine.api.EditorConfigOverride_Companion getEMPTY_EDITOR_CONFIG_OVERRIDE() → EditorConfigOverride

...✂

mateuszkwiecinski · 2023-04-21T21:41:22Z

gradle/libs.versions.toml

-ktlint-core = { module = "com.pinterest.ktlint:ktlint-core", version.ref = "maven-ktlint" }
+ktlint = { module = "com.pinterest:ktlint", version.ref = "maven-ktlint" }
+ktlint-rule-engine = { module = "com.pinterest.ktlint:ktlint-rule-engine", version.ref = "maven-ktlint" }
+ktlint-cli-ruleset-core = { module = "com.pinterest.ktlint:ktlint-cli-ruleset-core", version.ref = "maven-ktlint" }


Needed for com.pinterest.ktlint.cli.ruleset.core.api.RuleSetProviderV3

mateuszkwiecinski · 2023-04-21T21:43:14Z

gradle/libs.versions.toml

+ktlint = { module = "com.pinterest:ktlint", version.ref = "maven-ktlint" }
+ktlint-rule-engine = { module = "com.pinterest.ktlint:ktlint-rule-engine", version.ref = "maven-ktlint" }
+ktlint-cli-ruleset-core = { module = "com.pinterest.ktlint:ktlint-cli-ruleset-core", version.ref = "maven-ktlint" }
+ktlint-cli-reporter = { module = "com.pinterest.ktlint:ktlint-cli-reporter", version.ref = "maven-ktlint" }


Needed for ReporterV2/ReporterProviderV2, KtlintCliError (used in reporters)

mateuszkwiecinski · 2023-04-21T21:43:26Z

gradle/libs.versions.toml

 maven-commons = "2.11.0"

 [libraries]
 agp-gradle = { module = "com.android.tools.build:gradle", version.ref = "google-agp" }
 kotlin-gradle = { module = "org.jetbrains.kotlin:kotlin-gradle-plugin" }
-ktlint-core = { module = "com.pinterest.ktlint:ktlint-core", version.ref = "maven-ktlint" }
+ktlint = { module = "com.pinterest:ktlint", version.ref = "maven-ktlint" }
+ktlint-rule-engine = { module = "com.pinterest.ktlint:ktlint-rule-engine", version.ref = "maven-ktlint" }


This is the core part used to invoke ktlint, I'd expect this to be the only dependency needed :/

mateuszkwiecinski · 2023-04-21T21:44:52Z

gradle/libs.versions.toml

 maven-commons = "2.11.0"

 [libraries]
 agp-gradle = { module = "com.android.tools.build:gradle", version.ref = "google-agp" }
 kotlin-gradle = { module = "org.jetbrains.kotlin:kotlin-gradle-plugin" }
-ktlint-core = { module = "com.pinterest.ktlint:ktlint-core", version.ref = "maven-ktlint" }
+ktlint = { module = "com.pinterest:ktlint", version.ref = "maven-ktlint" }


Needed for Baseline

mateuszkwiecinski commented Apr 21, 2023

View reviewed changes

mateuszkwiecinski mentioned this pull request Apr 21, 2023

[0.49.0] loadBaseline loads invalid absolute paths when invoked from separate process/with different working directory pinterest/ktlint#1962

Closed

mateuszkwiecinski added 2 commits May 12, 2023 17:09

Bump Ktlint to 0.49.0

d5e5d92

Update consumer project

a97ca7e

mateuszkwiecinski force-pushed the mateuszkwiecinski/bump_ktlint_to_0_49_0 branch from ae96b4d to 45589ed Compare May 12, 2023 16:56

Bump ktlint to 0.49.1

8c28597

mateuszkwiecinski force-pushed the mateuszkwiecinski/bump_ktlint_to_0_49_0 branch from 45589ed to 8c28597 Compare May 12, 2023 21:52

mateuszkwiecinski changed the title ~~Bump Ktlint to 0.49.0~~ Bump Ktlint to 0.49.1 May 12, 2023

mateuszkwiecinski marked this pull request as ready for review May 12, 2023 22:31

mateuszkwiecinski merged commit f407bea into master May 13, 2023

mateuszkwiecinski deleted the mateuszkwiecinski/bump_ktlint_to_0_49_0 branch May 13, 2023 07:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump Ktlint to 0.49.1 #64

Bump Ktlint to 0.49.1 #64

mateuszkwiecinski commented Apr 21, 2023

github-actions bot commented Apr 21, 2023 •

edited

Loading

mateuszkwiecinski Apr 21, 2023

mateuszkwiecinski Apr 21, 2023

mateuszkwiecinski Apr 21, 2023

mateuszkwiecinski Apr 21, 2023

Bump Ktlint to 0.49.1 #64

Bump Ktlint to 0.49.1 #64

Conversation

mateuszkwiecinski commented Apr 21, 2023

github-actions bot commented Apr 21, 2023 • edited Loading

mateuszkwiecinski Apr 21, 2023

Choose a reason for hiding this comment

mateuszkwiecinski Apr 21, 2023

Choose a reason for hiding this comment

mateuszkwiecinski Apr 21, 2023

Choose a reason for hiding this comment

mateuszkwiecinski Apr 21, 2023

Choose a reason for hiding this comment

github-actions bot commented Apr 21, 2023 •

edited

Loading