Change: use build-tool for generating dbaas consumers in builds #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsformed types changed
20 tasks
shreddedbacon
changed the title
…go to mongodb-dbaas conversion
shreddedbacon
force-pushed
the
dbaas-templating
branch
2 times, most recently
from
09d54b9 to
124b28f
Compare
shreddedbacon
force-pushed
the
dbaas-templating
branch
from
124b28f to
11d5bcb
Compare
tobybellwood
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
This is looking good from my side. Tested with all DBaaS providers, in new and update scenarios. The correction of the environment labels is nice, and the addition of the annotations to the postgres consumer both work perfectly. Additionally it clears up a situation where the underlying image for the DBaaS-ed service was being copied into Harbor unnecessarily
Great piece of work. A++
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use build-deploy-tool to handle the creation of dbaas templates. This replaces the existing BASH process.
At the moment this is replacement of existing functionality, but I think it should also force failure of build on failure to provision dbaas #56, but this could be a follow up PR
Sub task of #27