Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more information about container-registry credential sourcing #131

Closed
wants to merge 4 commits into from

Conversation

shreddedbacon
Copy link
Member

Just some minor changes to the output of custom container registry information to display where the credential was sourced from to aid in debugging if required.

Also adds some header separators for the UI to split up sections

…ional information for container-registry credential sourcing
@shreddedbacon shreddedbacon marked this pull request as ready for review October 24, 2022 08:21
Schnitzel added a commit that referenced this pull request Oct 24, 2022
@shreddedbacon
Copy link
Member Author

Do we close out this one and #132 in favor of #133 (with the suggested fixes from #132)?

@tobybellwood
Copy link
Member

Do we close out this one and #132 in favor of #133 (with the suggested fixes from #132)?

If 133 is the complete package, lets just do that one?

@shreddedbacon
Copy link
Member Author

Closing in favor of #133

@shreddedbacon
Copy link
Member Author

Reopening, #133 contains other PRs not confirmed for merging yet

@shreddedbacon shreddedbacon reopened this Oct 27, 2022
@shreddedbacon
Copy link
Member Author

#132 contains this PR in it, so closing this again 🤦

@shreddedbacon shreddedbacon deleted the container-registries branch May 26, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants