feat: LAGOON_CONFIG_X variables to BUILD_ARGS and lagoon-env configmap for use in pods #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bomoko
force-pushed
the
feature/add-ssh-and-api-details-as-buildvars
branch
from
370fe92 to
705a56d
Compare
3 tasks
shreddedbacon
changed the title
This was referenced Aug 17, 2023
shreddedbacon
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds three new build args if present in build environment - $LAGOON_CONFIG_API_HOST, $LAGOON_CONFIG_TOKEN_HOST, and $LAGOON_CONFIG_TOKEN_PORT
also under consideration is adding the remote's ssh port and hostname.