Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fsGroupChangePolicy: "OnRootMismatch" to all deployments that use persistent bulk storage #234

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

Schnitzel
Copy link
Contributor

@Schnitzel Schnitzel commented Sep 28, 2023

fixes #235

@shreddedbacon
Copy link
Member

We have a file that is used by rootless workloads already that this would probably be better placed into, rather than each template individually: https://github.com/uselagoon/build-deploy-tool/blob/main/legacy/rootless.values.yaml

@smlx
Copy link
Member

smlx commented Sep 29, 2023

This might also need testing on at least the main hyperscalers, and provisioners used in CI similar to uselagoon/lagoon#2481 (comment)

I wouldn't be surprised if Azure does something exciting and different by default.

@shreddedbacon
Copy link
Member

shreddedbacon commented Sep 29, 2023

This might also need testing on at least the main hyperscalers, and provisioners used in CI similar to uselagoon/lagoon#2481 (comment)

I wouldn't be surprised if Azure does something exciting and different by default.

Yeah, I asked in the issue how this may impact on other provisioners, as there are so many.

It may be worth wrapping this in a feature flag for injection, and for AIO setting this flag to enabled on clusters using this driver?
https://gist.github.com/shreddedbacon/62df6b27c2989782c566a577ee75b484

@tobybellwood
Copy link
Member

yes - lets wrap this in a feature flag (FS_ON_ROOT_MISMATCH) for now whilst we look at the alternative NFS systems.

@tobybellwood tobybellwood merged commit c83e2f8 into main Oct 9, 2023
2 checks passed
@tobybellwood tobybellwood deleted the fsGroupChangePolicy-OnRootMismatch branch October 9, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for OnRootMismatch fsGroupChangePolicy
4 participants