Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add a check for username override key variable from api #263

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

shreddedbacon
Copy link
Member

This adds a username override key to internal container registry login in a similar manner to how #132 allowed for the password to be overridden.

Given the following container-registries block, and wanting to change the username for the account defined from robot$robotic to something else, you can add a project or environment variable of the scope container_registry with the name REGISTRY_my-harbor_USERNAME and set it to whichever username it should be instead.

container-registries:
  my-harbor:
    username: robot$robotic
    password: my-special-password
    url: harbor.example.com

With a verify script https://gist.github.com/shreddedbacon/892f8206282aed54c029ed1979b6fcb6

@shreddedbacon shreddedbacon force-pushed the container-registry-username-override-key branch from 62a5e86 to add872c Compare November 15, 2023 11:06
@shreddedbacon shreddedbacon force-pushed the container-registry-username-override-key branch from add872c to 4ab78f3 Compare November 15, 2023 11:10
@shreddedbacon shreddedbacon marked this pull request as ready for review November 20, 2023 01:20
@shreddedbacon shreddedbacon added this to the v2.17 milestone Nov 27, 2023
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, working in cluster

@shreddedbacon shreddedbacon merged commit c8b6c28 into main Nov 27, 2023
2 checks passed
@shreddedbacon shreddedbacon deleted the container-registry-username-override-key branch November 27, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants